From 0ee498e31ea8112f11fa37fee91c0393fbbb92ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Balet?= Date: Tue, 16 Apr 2024 11:29:27 +0200 Subject: [PATCH 1/2] perf(directive): as standalone --- projects/uiowa/digit-only/README.md | 10 ++++++++-- .../digit-only/src/lib/digit-only.directive.ts | 1 + .../uiowa/digit-only/src/lib/digit-only.module.ts | 10 ---------- .../uiowa/digit-only/src/lib/mask.directive.ts | 1 + projects/uiowa/digit-only/src/public-api.ts | 1 - src/app/app.module.ts | 15 ++++++++++----- .../digit-only-demos.component.ts | 5 ++--- src/app/mask-demos/mask-demos.component.ts | 13 +++---------- 8 files changed, 25 insertions(+), 31 deletions(-) delete mode 100644 projects/uiowa/digit-only/src/lib/digit-only.module.ts diff --git a/projects/uiowa/digit-only/README.md b/projects/uiowa/digit-only/README.md index 683c831..404a64e 100644 --- a/projects/uiowa/digit-only/README.md +++ b/projects/uiowa/digit-only/README.md @@ -67,7 +67,10 @@ npm i @uiowa/digit-only ```typescript // in your Angular module -import { DigitOnlyModule } from '@uiowa/digit-only'; +import { + DigitOnlyDirective, + MaskDirective, +} from '@uiowa/digit-only'; @NgModule({ declarations: [ @@ -75,7 +78,10 @@ import { DigitOnlyModule } from '@uiowa/digit-only'; ], imports: [ BrowserModule, - DigitOnlyModule + + // DigitOnly + DigitOnlyDirective, + MaskDirective, ], ... }) diff --git a/projects/uiowa/digit-only/src/lib/digit-only.directive.ts b/projects/uiowa/digit-only/src/lib/digit-only.directive.ts index 4a9d58e..ff48ddf 100644 --- a/projects/uiowa/digit-only/src/lib/digit-only.directive.ts +++ b/projects/uiowa/digit-only/src/lib/digit-only.directive.ts @@ -8,6 +8,7 @@ import { } from '@angular/core'; @Directive({ + standalone: true, selector: '[digitOnly]', }) export class DigitOnlyDirective implements OnChanges { diff --git a/projects/uiowa/digit-only/src/lib/digit-only.module.ts b/projects/uiowa/digit-only/src/lib/digit-only.module.ts deleted file mode 100644 index b4893e6..0000000 --- a/projects/uiowa/digit-only/src/lib/digit-only.module.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { NgModule } from '@angular/core'; -import { DigitOnlyDirective } from './digit-only.directive'; -import { MaskDirective } from './mask.directive'; - -@NgModule({ - imports: [], - declarations: [DigitOnlyDirective, MaskDirective], - exports: [DigitOnlyDirective, MaskDirective], -}) -export class DigitOnlyModule {} diff --git a/projects/uiowa/digit-only/src/lib/mask.directive.ts b/projects/uiowa/digit-only/src/lib/mask.directive.ts index 3ed0070..95ecaa4 100644 --- a/projects/uiowa/digit-only/src/lib/mask.directive.ts +++ b/projects/uiowa/digit-only/src/lib/mask.directive.ts @@ -1,6 +1,7 @@ import { Directive, ElementRef, HostListener, OnInit } from '@angular/core'; @Directive({ + standalone: true, selector: '[mask]', }) export class MaskDirective implements OnInit { diff --git a/projects/uiowa/digit-only/src/public-api.ts b/projects/uiowa/digit-only/src/public-api.ts index 037664d..9a6f942 100644 --- a/projects/uiowa/digit-only/src/public-api.ts +++ b/projects/uiowa/digit-only/src/public-api.ts @@ -4,4 +4,3 @@ export * from './lib/digit-only.directive'; export * from './lib/mask.directive'; -export * from './lib/digit-only.module'; diff --git a/src/app/app.module.ts b/src/app/app.module.ts index 5b63b62..f3b2393 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -1,26 +1,31 @@ -import { BrowserModule } from '@angular/platform-browser'; -import { FormsModule } from '@angular/forms'; import { NgModule } from '@angular/core'; +import { FormsModule } from '@angular/forms'; +import { BrowserModule } from '@angular/platform-browser'; import { RouterModule } from '@angular/router'; +import { + DigitOnlyDirective, + MaskDirective, +} from '../../projects/uiowa/digit-only/src/public-api'; import { AppComponent } from './app.component'; import { DigitOnlyDemosComponent } from './digit-only-demos/digit-only-demos.component'; import { MaskDemosComponent } from './mask-demos/mask-demos.component'; -import { DigitOnlyModule } from '../../projects/uiowa/digit-only/src/public-api'; -// import { DigitOnlyModule } from '@uiowa/digit-only'; @NgModule({ declarations: [AppComponent, DigitOnlyDemosComponent, MaskDemosComponent], imports: [ BrowserModule, FormsModule, - DigitOnlyModule, RouterModule.forRoot([ { path: '', pathMatch: 'full', redirectTo: 'demo' }, { path: 'demo', component: DigitOnlyDemosComponent }, { path: 'mask', component: MaskDemosComponent }, { path: '**', redirectTo: '' }, ]), + + // DigitOnly + DigitOnlyDirective, + MaskDirective, ], providers: [], bootstrap: [AppComponent], diff --git a/src/app/digit-only-demos/digit-only-demos.component.ts b/src/app/digit-only-demos/digit-only-demos.component.ts index c78ed81..fd70840 100644 --- a/src/app/digit-only-demos/digit-only-demos.component.ts +++ b/src/app/digit-only-demos/digit-only-demos.component.ts @@ -1,11 +1,11 @@ -import { Component, OnInit } from '@angular/core'; +import { Component } from '@angular/core'; @Component({ selector: 'app-digit-only-demos', templateUrl: './digit-only-demos.component.html', styleUrls: ['./digit-only-demos.component.css'], }) -export class DigitOnlyDemosComponent implements OnInit { +export class DigitOnlyDemosComponent { amount: string = ''; min = 0; max = 10; @@ -14,7 +14,6 @@ export class DigitOnlyDemosComponent implements OnInit { constructor() {} - ngOnInit(): void {} watchAmountValue() { const value = Number(this.amount); this.amount = value.toFixed(2); diff --git a/src/app/mask-demos/mask-demos.component.ts b/src/app/mask-demos/mask-demos.component.ts index 1b863dd..0230af0 100644 --- a/src/app/mask-demos/mask-demos.component.ts +++ b/src/app/mask-demos/mask-demos.component.ts @@ -1,15 +1,8 @@ -import { Component, OnInit } from '@angular/core'; +import { Component } from '@angular/core'; @Component({ selector: 'app-mask-demos', templateUrl: './mask-demos.component.html', - styleUrls: ['./mask-demos.component.css'] + styleUrls: ['./mask-demos.component.css'], }) -export class MaskDemosComponent implements OnInit { - - constructor() { } - - ngOnInit(): void { - } - -} +export class MaskDemosComponent {} From c41682d9401fc362e0402cfb79b647b84162a8cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Balet?= Date: Tue, 16 Apr 2024 11:30:17 +0200 Subject: [PATCH 2/2] fix(peerDependencies): min angular version --- projects/uiowa/digit-only/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/uiowa/digit-only/package.json b/projects/uiowa/digit-only/package.json index 07f7362..1d9c5e3 100644 --- a/projects/uiowa/digit-only/package.json +++ b/projects/uiowa/digit-only/package.json @@ -20,8 +20,8 @@ }, "license": "MIT", "peerDependencies": { - "@angular/common": ">=12.0.0", - "@angular/core": ">=12.0.0" + "@angular/common": ">=16.0.0", + "@angular/core": ">=16.0.0" }, "dependencies": { "tslib": "^2.3.0"