From 9d1761307e09d01a53be1e13ec7a22a961ad7ab4 Mon Sep 17 00:00:00 2001 From: Wanderson Ferreira Date: Sun, 10 Oct 2021 01:37:26 -0300 Subject: [PATCH] sometimes we dont have top level comments --- github-review.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/github-review.el b/github-review.el index f4f7204..7b41445 100644 --- a/github-review.el +++ b/github-review.el @@ -436,11 +436,13 @@ This function infers the PR name based on the current filename" (lambda (&rest _) (message "Done submitting review replies")))) - (github-review-post-review - pr-alist - review - (lambda (&rest _) - (message "Done submitting review"))))) + (when (or regular-comments + (not (string-empty-p (a-get review 'body)))) + (github-review-post-review + pr-alist + review + (lambda (&rest _) + (message "Done submitting review")))))) (defun github-review-to-comments (text) "Convert TEXT, a string to a string where each line is prefixed by ~."