Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume DISABLE_METRICS=false when serviceMonitor is enabled #39

Open
jtackaberry opened this issue Mar 3, 2022 · 0 comments
Open

Assume DISABLE_METRICS=false when serviceMonitor is enabled #39

jtackaberry opened this issue Mar 3, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jtackaberry
Copy link

Small quality-of-life enhancement suggestion:

If serviceMonitor.enabled is true, it stands to reason that the administrator intends for metrics to be scraped. In this case, env.open.DISABLE_METRICS should default to false unless explicitly overridden by user-supplied chart values.
@cbuto cbuto added the good first issue Good for newcomers label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtackaberry @cbuto