Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version in plugin.yaml for tag 0.10.2 #134

Open
dani-CO-CN opened this issue Mar 2, 2022 · 6 comments
Open

Update version in plugin.yaml for tag 0.10.2 #134

dani-CO-CN opened this issue Mar 2, 2022 · 6 comments

Comments

@dani-CO-CN
Copy link

It seems that in the last (0.10.2) release the version in plugin.yaml was not increased and is still on version v0.10.1

https://github.com/chartmuseum/helm-push/blob/v0.10.2/plugin.yaml#L2

name: "cm-push"
version: "0.10.1"
usage: "Please see https://github.com/chartmuseum/helm-push for usage"
description: "Push chart package to ChartMuseum"
....
@cbuto
Copy link
Contributor

cbuto commented Mar 9, 2022

thanks for reporting this @dani-CO-CN, looks like the v0.10.2 tag is missing the commit that bumped that version 🤔

@jdolitsky
Copy link
Contributor

when you install the plugin, I believe helm looks directly at whats on main branch.

@dani-CO-CN is this making plugin unusable in any way? Or just noting the discrepancy?

@jdolitsky
Copy link
Contributor

to be clear - this version should have been bumped prior to release, and that is my mistake

@dani-CO-CN
Copy link
Author

dani-CO-CN commented Mar 9, 2022

No, not that i know of. I just ran the install in a ci pipeline with a tagged version of helm-push and the installer kept telling me that it installed v0.10.1, took me a while to figure out what was going on 😄

helm plugin install --version=v0.10.2 https://github.com/chartmuseum/helm-push

@mmontes11
Copy link

First of all, thanks for this plugin, works grat.

Any updates on this topic? I see that the plugin.yml has been updated in the main repo but hasn't been released yet.

@outime
Copy link

outime commented Jun 23, 2022

@jdolitsky could you please take a look? It's specially important since only 0.10.2 has the arm64 version as opposed to 0.10.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants