From 0d71b246e6cc11df3256cdef302d9662bafeadcf Mon Sep 17 00:00:00 2001 From: saz97 <152467061+saz97@users.noreply.github.com> Date: Wed, 26 Jun 2024 17:47:21 +0800 Subject: [PATCH] refactor: geo related tcl tests (#2753) * modify geo.tcl ci * modify go_test * modify default.conf * modify code based on review --- src/pika_geo.cc | 45 +- src/pika_geohash_helper.cc | 67 +-- src/storage/src/redis_zsets.cc | 3 +- tests/assets/default.conf | 2 +- tests/integration/geo_test.go | 2 +- tests/unit/geo.tcl | 2 +- tests/unit/type/geo.tcl | 798 +++++++++++++++++++++++++++++++++ 7 files changed, 875 insertions(+), 44 deletions(-) create mode 100644 tests/unit/type/geo.tcl diff --git a/src/pika_geo.cc b/src/pika_geo.cc index c72451a556..acb7d38dcb 100644 --- a/src/pika_geo.cc +++ b/src/pika_geo.cc @@ -10,6 +10,7 @@ #include "pstd/include/pstd_string.h" #include "include/pika_geohash_helper.h" +#include "rocksdb/status.h" void GeoAddCmd::DoInitial() { if (!CheckArg(argv_.size())) { @@ -59,7 +60,7 @@ void GeoAddCmd::Do() { rocksdb::Status s = db_->storage()->ZAdd(key_, score_members, &count); if (s.ok()) { res_.AppendInteger(count); - } else if (s_.IsInvalidArgument()) { + } else if (s.IsInvalidArgument()) { res_.SetRes(CmdRes::kMultiKey); } else { res_.SetRes(CmdRes::kErrOther, s.ToString()); @@ -103,7 +104,7 @@ void GeoPosCmd::Do() { } else if (s.IsNotFound()) { res_.AppendStringLen(-1); continue; - } else if (s_.IsInvalidArgument()) { + } else if (s.IsInvalidArgument()) { res_.SetRes(CmdRes::kMultiKey); continue; } else { @@ -163,13 +164,14 @@ void GeoDistCmd::Do() { double first_xy[2]; double second_xy[2]; rocksdb::Status s = db_->storage()->ZScore(key_, first_pos_, &first_score); + if (s.ok()) { GeoHashBits hash = {.bits = static_cast(first_score), .step = GEO_STEP_MAX}; geohashDecodeToLongLatWGS84(hash, first_xy); } else if (s.IsNotFound()) { res_.AppendStringLen(-1); return; - } else if (s_.IsInvalidArgument()) { + } else if (s.IsInvalidArgument()) { res_.SetRes(CmdRes::kMultiKey); return; } else { @@ -241,7 +243,7 @@ void GeoHashCmd::Do() { } else if (s.IsNotFound()) { res_.AppendStringLen(-1); continue; - } else if (s_.IsInvalidArgument()) { + } else if (s.IsInvalidArgument()) { res_.SetRes(CmdRes::kMultiKey); continue; } else { @@ -300,6 +302,7 @@ static void GetAllNeighbors(const std::shared_ptr& db, std::string& key, Geo if (HASHISZERO(neighbors[i])) { continue; } + min = geohashAlign52Bits(neighbors[i]); neighbors[i].bits++; max = geohashAlign52Bits(neighbors[i]); @@ -312,8 +315,13 @@ static void GetAllNeighbors(const std::shared_ptr& db, std::string& key, Geo std::vector score_members; s = db->storage()->ZRangebyscore(key, static_cast(min), static_cast(max), true, true, &score_members); if (!s.ok() && !s.IsNotFound()) { - res.SetRes(CmdRes::kErrOther, s.ToString()); - return; + if (s.IsInvalidArgument()) { + res.SetRes(CmdRes::kMultiKey); + return; + } else { + res.SetRes(CmdRes::kErrOther, s.ToString()); + return; + } } // Insert into result only if the point is within the search area. for (auto & score_member : score_members) { @@ -339,12 +347,14 @@ static void GetAllNeighbors(const std::shared_ptr& db, std::string& key, Geo count_limit = static_cast(result.size()); } // If using sort option - if (range.sort == Asc) { - std::sort(result.begin(), result.end(), sort_distance_asc); - } else if (range.sort == Desc) { - std::sort(result.begin(), result.end(), sort_distance_desc); + if (range.sort != Unsort) { + if (range.sort == Asc) { + std::sort(result.begin(), result.end(), sort_distance_asc); + } else if (range.sort == Desc) { + std::sort(result.begin(), result.end(), sort_distance_desc); + } } - + if (range.store || range.storedist) { // Target key, create a sorted set with the results. std::vector score_members; @@ -354,10 +364,18 @@ static void GetAllNeighbors(const std::shared_ptr& db, std::string& key, Geo score_members.push_back({score, result[i].member}); } int32_t count = 0; + int32_t card = db->storage()->Exists({range.storekey}); + if (card) { + if (db->storage()->Del({range.storekey}) > 0){ + db->cache()->Del({range.storekey}); + } + } s = db->storage()->ZAdd(range.storekey, score_members, &count); if (!s.ok()) { res.SetRes(CmdRes::kErrOther, s.ToString()); return; + } else { + s = db->cache()->ZAdd(range.storekey, score_members); } res.AppendInteger(count_limit); return; @@ -426,6 +444,7 @@ void GeoRadiusCmd::DoInitial() { return; } size_t pos = 6; + range_.sort = Asc; while (pos < argv_.size()) { if (strcasecmp(argv_[pos].c_str(), "withdist") == 0) { range_.withdist = true; @@ -555,6 +574,10 @@ void GeoRadiusByMemberCmd::DoInitial() { void GeoRadiusByMemberCmd::Do() { double score = 0.0; rocksdb::Status s = db_->storage()->ZScore(key_, range_.member, &score); + if (s.IsNotFound() && !s.ToString().compare("NotFound: Invalid member")) { + res_.SetRes(CmdRes::kErrOther, "could not decode requested zset member"); + return; + } if (s.ok()) { double xy[2]; GeoHashBits hash = {.bits = static_cast(score), .step = GEO_STEP_MAX}; diff --git a/src/pika_geohash_helper.cc b/src/pika_geohash_helper.cc index e2f58725b9..bc671de7dc 100644 --- a/src/pika_geohash_helper.cc +++ b/src/pika_geohash_helper.cc @@ -38,7 +38,6 @@ #include "include/pika_geohash_helper.h" // #include "debugmacro.h" #include - #define D_R (M_PI / 180.0) #define R_MAJOR 6378137.0 #define R_MINOR 6356752.3142 @@ -79,7 +78,6 @@ uint8_t geohashEstimateStepsByRadius(double range_meters, double lat) { step--; } } - /* Frame to valid range. */ if (step < 1) { step = 1; @@ -112,11 +110,19 @@ int geohashBoundingBox(double longitude, double latitude, double radius_meters, if (!bounds) { return 0; } + double height = radius_meters; + double width = radius_meters; + + const double lat_delta = rad_deg(height/EARTH_RADIUS_IN_METERS); + const double long_delta_top = rad_deg(width/EARTH_RADIUS_IN_METERS/cos(deg_rad(latitude+lat_delta))); + const double long_delta_bottom = rad_deg(width/EARTH_RADIUS_IN_METERS/cos(deg_rad(latitude-lat_delta))); + + int southern_hemisphere = latitude < 0 ? 1 : 0; + bounds[0] = southern_hemisphere ? longitude-long_delta_bottom : longitude-long_delta_top; + bounds[2] = southern_hemisphere ? longitude+long_delta_bottom : longitude+long_delta_top; + bounds[1] = latitude - lat_delta; + bounds[3] = latitude + lat_delta; - bounds[0] = longitude - rad_deg(radius_meters / EARTH_RADIUS_IN_METERS / cos(deg_rad(latitude))); - bounds[2] = longitude + rad_deg(radius_meters / EARTH_RADIUS_IN_METERS / cos(deg_rad(latitude))); - bounds[1] = latitude - rad_deg(radius_meters / EARTH_RADIUS_IN_METERS); - bounds[3] = latitude + rad_deg(radius_meters / EARTH_RADIUS_IN_METERS); return 1; } @@ -141,14 +147,12 @@ GeoHashRadius geohashGetAreasByRadius(double longitude, double latitude, double min_lat = bounds[1]; max_lon = bounds[2]; max_lat = bounds[3]; - steps = geohashEstimateStepsByRadius(radius_meters, latitude); - + geohashGetCoordRange(&long_range, &lat_range); geohashEncode(&long_range, &lat_range, longitude, latitude, steps, &hash); geohashNeighbors(&hash, &neighbors); geohashDecode(long_range, lat_range, hash, &area); - /* Check if the step is enough at the limits of the covered area. * Sometimes when the search area is near an edge of the * area, the estimated step is not small enough, since one of the @@ -166,20 +170,19 @@ GeoHashRadius geohashGetAreasByRadius(double longitude, double latitude, double geohashDecode(long_range, lat_range, neighbors.east, &east); geohashDecode(long_range, lat_range, neighbors.west, &west); - if (geohashGetDistance(longitude, latitude, longitude, north.latitude.max) < radius_meters) { + if (north.latitude.max < max_lat) { decrease_step = 1; } - if (geohashGetDistance(longitude, latitude, longitude, south.latitude.min) < radius_meters) { + if (south.latitude.min > min_lat) { decrease_step = 1; } - if (geohashGetDistance(longitude, latitude, east.longitude.max, latitude) < radius_meters) { + if (east.longitude.max < max_lon) { decrease_step = 1; } - if (geohashGetDistance(longitude, latitude, west.longitude.min, latitude) < radius_meters) { + if (west.longitude.min > min_lon) { decrease_step = 1; } } - if (steps > 1 && (decrease_step != 0)) { steps--; geohashEncode(&long_range, &lat_range, longitude, latitude, steps, &hash); @@ -225,22 +228,28 @@ GeoHashFix52Bits geohashAlign52Bits(const GeoHashBits& hash) { bits <<= (52 - hash.step * 2); return bits; } - -/* Calculate distance using haversin great circle distance formula. */ +/* Calculate distance using simplified haversine great circle distance formula. + * Given longitude diff is 0 the asin(sqrt(a)) on the haversine is asin(sin(abs(u))). + * arcsin(sin(x)) equal to x when x ∈[−𝜋/2,𝜋/2]. Given latitude is between [−𝜋/2,𝜋/2] + * we can simplify arcsin(sin(x)) to x. + */ +double geohashGetLatDistance(double lat1d, double lat2d) { + return EARTH_RADIUS_IN_METERS * fabs(deg_rad(lat2d) - deg_rad(lat1d)); +} +/* Calculate distance using haversine great circle distance formula. */ double geohashGetDistance(double lon1d, double lat1d, double lon2d, double lat2d) { - double lat1r; - double lon1r; - double lat2r; - double lon2r; - double u; - double v; - lat1r = deg_rad(lat1d); - lon1r = deg_rad(lon1d); - lat2r = deg_rad(lat2d); - lon2r = deg_rad(lon2d); - u = sin((lat2r - lat1r) / 2); - v = sin((lon2r - lon1r) / 2); - return 2.0 * EARTH_RADIUS_IN_METERS * asin(sqrt(u * u + cos(lat1r) * cos(lat2r) * v * v)); + double lat1r, lon1r, lat2r, lon2r, u, v, a; + lon1r = deg_rad(lon1d); + lon2r = deg_rad(lon2d); + v = sin((lon2r - lon1r) / 2); + /* if v == 0 we can avoid doing expensive math when lons are practically the same */ + if (v == 0.0) + return geohashGetLatDistance(lat1d, lat2d); + lat1r = deg_rad(lat1d); + lat2r = deg_rad(lat2d); + u = sin((lat2r - lat1r) / 2); + a = u * u + cos(lat1r) * cos(lat2r) * v * v; + return 2.0 * EARTH_RADIUS_IN_METERS * asin(sqrt(a)); } int geohashGetDistanceIfInRadius(double x1, double y1, double x2, double y2, double radius, double* distance) { diff --git a/src/storage/src/redis_zsets.cc b/src/storage/src/redis_zsets.cc index ce89afe885..cdbf866c46 100644 --- a/src/storage/src/redis_zsets.cc +++ b/src/storage/src/redis_zsets.cc @@ -517,7 +517,6 @@ Status Redis::ZRange(const Slice& key, int32_t start, int32_t stop, std::vector< } int32_t cur_index = 0; ScoreMember score_member; - ZSetsScoreKey zsets_score_key(key, version, std::numeric_limits::lowest(), Slice()); KeyStatisticsDurationGuard guard(this, DataType::kZSets, key.ToString()); rocksdb::Iterator* iter = db_->NewIterator(read_options, handles_[kZsetsScoreCF]); @@ -1187,6 +1186,8 @@ Status Redis::ZScore(const Slice& key, const Slice& member, double* score) { uint64_t tmp = DecodeFixed64(data_value.data()); const void* ptr_tmp = reinterpret_cast(&tmp); *score = *reinterpret_cast(ptr_tmp); + } else if (s.IsNotFound()) { + return Status::NotFound("Invalid member"); } else { return s; } diff --git a/tests/assets/default.conf b/tests/assets/default.conf index d5d1318f5c..468d253e89 100644 --- a/tests/assets/default.conf +++ b/tests/assets/default.conf @@ -567,4 +567,4 @@ cache-lfu-decay-time: 1 # Warning: Ensure that the Settings of rename-command on the master and slave servers are consistent # # Example: -# rename-command : FLUSHDB 360flushdb \ No newline at end of file +# rename-command : FLUSHDB 360flushdb diff --git a/tests/integration/geo_test.go b/tests/integration/geo_test.go index df94609e45..382b97a8b0 100644 --- a/tests/integration/geo_test.go +++ b/tests/integration/geo_test.go @@ -53,7 +53,7 @@ var _ = Describe("Geo Commands", func() { Expect(res.Err()).NotTo(HaveOccurred()) Expect(res.Val()).To(HaveLen(2)) - Expect(res.Val()).To(Equal([]interface{}{[]interface{}{"Palermo", "190.4424", []interface{}{"13.361389338970184", "38.115556395496299"}}, []interface{}{"Catania", "56.4413", []interface{}{"15.087267458438873", "37.50266842333162"}}})) + Expect(res.Val()).To(Equal([]interface{}{[]interface{}{"Catania", "56.4413", []interface{}{"15.087267458438873", "37.50266842333162"}}, []interface{}{"Palermo", "190.4424", []interface{}{"13.361389338970184", "38.115556395496299"}}})) }) diff --git a/tests/unit/geo.tcl b/tests/unit/geo.tcl index 30914fe9f0..1c4d8a1a37 100644 --- a/tests/unit/geo.tcl +++ b/tests/unit/geo.tcl @@ -99,7 +99,7 @@ start_server {tags {"geo"}} { test {GEORADIUS with COUNT} { r georadius nyc -73.9798091 40.7598464 10 km COUNT 3 - } {{wtc one} {union square} {central park n/q/r}} + } {{central park n/q/r} 4545 {union square}} test {GEORADIUS with COUNT but missing integer argument} { catch {r georadius nyc -73.9798091 40.7598464 10 km COUNT} e diff --git a/tests/unit/type/geo.tcl b/tests/unit/type/geo.tcl new file mode 100644 index 0000000000..8bfaf233c6 --- /dev/null +++ b/tests/unit/type/geo.tcl @@ -0,0 +1,798 @@ +# Helper functions to simulate search-in-radius in the Tcl side in order to +# verify the Redis implementation with a fuzzy test. +proc geo_degrad deg {expr {$deg*(atan(1)*8/360)}} +proc geo_raddeg rad {expr {$rad/(atan(1)*8/360)}} + +proc geo_distance {lon1d lat1d lon2d lat2d} { + set lon1r [geo_degrad $lon1d] + set lat1r [geo_degrad $lat1d] + set lon2r [geo_degrad $lon2d] + set lat2r [geo_degrad $lat2d] + set v [expr {sin(($lon2r - $lon1r) / 2)}] + set u [expr {sin(($lat2r - $lat1r) / 2)}] + expr {2.0 * 6372797.560856 * \ + asin(sqrt($u * $u + cos($lat1r) * cos($lat2r) * $v * $v))} +} + +proc geo_random_point {lonvar latvar} { + upvar 1 $lonvar lon + upvar 1 $latvar lat + # Note that the actual latitude limit should be -85 to +85, we restrict + # the test to -70 to +70 since in this range the algorithm is more precise + # while outside this range occasionally some element may be missing. + set lon [expr {-180 + rand()*360}] + set lat [expr {-70 + rand()*140}] +} + +# Return elements non common to both the lists. +# This code is from http://wiki.tcl.tk/15489 +proc compare_lists {List1 List2} { + set DiffList {} + foreach Item $List1 { + if {[lsearch -exact $List2 $Item] == -1} { + lappend DiffList $Item + } + } + foreach Item $List2 { + if {[lsearch -exact $List1 $Item] == -1} { + if {[lsearch -exact $DiffList $Item] == -1} { + lappend DiffList $Item + } + } + } + return $DiffList +} + +# return true If a point in circle. +# search_lon and search_lat define the center of the circle, +# and lon, lat define the point being searched. +proc pointInCircle {radius_km lon lat search_lon search_lat} { + set radius_m [expr {$radius_km*1000}] + set distance [geo_distance $lon $lat $search_lon $search_lat] + if {$distance < $radius_m} { + return true + } + return false +} + +# return true If a point in rectangle. +# search_lon and search_lat define the center of the rectangle, +# and lon, lat define the point being searched. +# error: can adjust the width and height of the rectangle according to the error +proc pointInRectangle {width_km height_km lon lat search_lon search_lat error} { + set width_m [expr {$width_km*1000*$error/2}] + set height_m [expr {$height_km*1000*$error/2}] + set lon_distance [geo_distance $lon $lat $search_lon $lat] + set lat_distance [geo_distance $lon $lat $lon $search_lat] + + if {$lon_distance > $width_m || $lat_distance > $height_m} { + return false + } + return true +} + +proc verify_geo_edge_response_bylonlat {expected_response expected_store_response} { + catch {r georadius src{t} 1 1 1 km} response + assert_match $expected_response $response + + catch {r georadius src{t} 1 1 1 km store dest{t}} response + assert_match $expected_store_response $response + # Pika does not support the command + # catch {r geosearch src{t} fromlonlat 0 0 byradius 1 km} response + # assert_match $expected_response $response + + # catch {r geosearchstore dest{t} src{t} fromlonlat 0 0 byradius 1 km} response + # assert_match $expected_store_response $response +} + +proc verify_geo_edge_response_bymember {expected_response expected_store_response} { + catch {r georadiusbymember src{t} member 1 km} response + assert_match $expected_response $response + + catch {r georadiusbymember src{t} member 1 km store dest{t}} response + assert_match $expected_store_response $response + + # Pika does not support the command + # catch {r geosearch src{t} frommember member bybox 1 1 km} response + # assert_match $expected_response $response + + # catch {r geosearchstore dest{t} src{t} frommember member bybox 1 1 m} response + # assert_match $expected_store_response $response +} + +proc verify_geo_edge_response_generic {expected_response} { + catch {r geodist src{t} member 1 km} response + assert_match $expected_response $response + + catch {r geohash src{t} member} response + assert_match $expected_response $response + + catch {r geopos src{t} member} response + assert_match $expected_response $response +} + + +# The following list represents sets of random seed, search position +# and radius that caused bugs in the past. It is used by the randomized +# test later as a starting point. When the regression vectors are scanned +# the code reverts to using random data. +# +# The format is: seed km lon lat +set regression_vectors { + {1482225976969 7083 81.634948934258375 30.561509253718668} + {1482340074151 5416 -70.863281847379767 -46.347003465679947} + {1499014685896 6064 -89.818768962202014 -40.463868561416803} + {1412 156 149.29737817929004 15.95807862745508} + {441574 143 59.235461856813856 66.269555127373678} + {160645 187 -101.88575239939883 49.061997951502917} + {750269 154 -90.187939661642517 66.615930412251487} + {342880 145 163.03472387745728 64.012747720821181} + {729955 143 137.86663517256579 63.986745399416776} + {939895 151 59.149620271823181 65.204186651485145} + {1412 156 149.29737817929004 15.95807862745508} + {564862 149 84.062063109158544 -65.685403922426232} + {1546032440391 16751 -1.8175081637769495 20.665668878082954} +} +set rv_idx 0 + +start_server {tags {"geo"}} { + test {GEO with wrong type src key} { + r set src{t} wrong_type + + verify_geo_edge_response_bylonlat "WRONGTYPE*" "WRONGTYPE*" + verify_geo_edge_response_bymember "WRONGTYPE*" "WRONGTYPE*" + verify_geo_edge_response_generic "WRONGTYPE*" + } + + test {GEO with non existing src key} { + r del src{t} + + verify_geo_edge_response_bylonlat {} 0 + verify_geo_edge_response_bymember {} 0 + } + + test {GEO BYLONLAT with empty search} { + r del src{t} + r geoadd src{t} 13.361389 38.115556 "Palermo" 15.087269 37.502669 "Catania" + + verify_geo_edge_response_bylonlat {} 0 + } + + test {GEO BYMEMBER with non existing member} { + r del src{t} + r geoadd src{t} 13.361389 38.115556 "Palermo" 15.087269 37.502669 "Catania" + + verify_geo_edge_response_bymember "ERR*" "ERR*" + } + + test {GEOADD create} { + r geoadd nyc -73.9454966 40.747533 "lic market" + } {1} + + test {GEOADD update} { + r geoadd nyc -73.9454966 40.747533 "lic market" + } {0} + # Pika does not support the command + # test {GEOADD update with CH option} { + # assert_equal 1 [r geoadd nyc CH 40.747533 -73.9454966 "lic market"] + # lassign [lindex [r geopos nyc "lic market"] 0] x1 y1 + # assert {abs($x1) - 40.747 < 0.001} + # assert {abs($y1) - 73.945 < 0.001} + # } {} + + # Pika does not support the command + # test {GEOADD update with NX option} { + # assert_equal 0 [r geoadd nyc NX -73.9454966 40.747533 "lic market"] + # lassign [lindex [r geopos nyc "lic market"] 0] x1 y1 + # assert {abs($x1) - 40.747 < 0.001} + # assert {abs($y1) - 73.945 < 0.001} + # } {} + + # Pika does not support the command + # test {GEOADD update with XX option} { + # assert_equal 0 [r geoadd nyc XX -83.9454966 40.747533 "lic market"] + # lassign [lindex [r geopos nyc "lic market"] 0] x1 y1 + # assert {abs($x1) - 83.945 < 0.001} + # assert {abs($y1) - 40.747 < 0.001} + # } {} + + # Pika does not support the command + # test {GEOADD update with CH NX option} { + # r geoadd nyc CH NX -73.9454966 40.747533 "lic market" + # } {0} + + # Pika does not support the command + # test {GEOADD update with CH XX option} { + # r geoadd nyc CH XX -73.9454966 40.747533 "lic market" + # } {1} + + # Pika does not support the command + # test {GEOADD update with XX NX option will return syntax error} { + # catch { + # r geoadd nyc xx nx -73.9454966 40.747533 "lic market" + # } err + # set err + # } {ERR *syntax*} + + # Pika does not support the command + # test {GEOADD update with invalid option} { + # catch { + # r geoadd nyc ch xx foo -73.9454966 40.747533 "lic market" + # } err + # set err + # } {ERR *syntax*} + + test {GEOADD invalid coordinates} { + catch { + r geoadd nyc -73.9454966 40.747533 "lic market" \ + foo bar "luck market" + } err + set err + } {*valid*} + + test {GEOADD multi add} { + r geoadd nyc -73.9733487 40.7648057 "central park n/q/r" -73.9903085 40.7362513 "union square" -74.0131604 40.7126674 "wtc one" -73.7858139 40.6428986 "jfk" -73.9375699 40.7498929 "q4" -73.9564142 40.7480973 4545 + } {6} + + test {Check geoset values} { + r zrange nyc 0 -1 withscores + } {{wtc one} 1791873972053020 {union square} 1791875485187452 {central park n/q/r} 1791875761332224 4545 1791875796750882 {lic market} 1791875804419201 q4 1791875830079666 jfk 1791895905559723} + + test {GEORADIUS simple (sorted)} { + r georadius nyc -73.9798091 40.7598464 3 km asc + } {{central park n/q/r} 4545 {union square}} + + # Pika does not support the command + # test {GEORADIUS_RO simple (sorted)} { + # r georadius_ro nyc -73.9798091 40.7598464 3 km asc + # } {{central park n/q/r} 4545 {union square}} + + # Pika does not support the command + # test {GEOSEARCH simple (sorted)} { + # r geosearch nyc fromlonlat -73.9798091 40.7598464 bybox 6 6 km asc + # } {{central park n/q/r} 4545 {union square} {lic market}} + + # Pika does not support the command + # test {GEOSEARCH FROMLONLAT and FROMMEMBER cannot exist at the same time} { + # catch {r geosearch nyc fromlonlat -73.9798091 40.7598464 frommember xxx bybox 6 6 km asc} e + # set e + # } {ERR *syntax*} + + # Pika does not support the command + # test {GEOSEARCH FROMLONLAT and FROMMEMBER one must exist} { + # catch {r geosearch nyc bybox 3 3 km asc desc withhash withdist withcoord} e + # set e + # } {ERR *exactly one of FROMMEMBER or FROMLONLAT*} + + # Pika does not support the command + # test {GEOSEARCH BYRADIUS and BYBOX cannot exist at the same time} { + # catch {r geosearch nyc fromlonlat -73.9798091 40.7598464 byradius 3 km bybox 3 3 km asc} e + # set e + # } {ERR *syntax*} + + # Pika does not support the command + # test {GEOSEARCH BYRADIUS and BYBOX one must exist} { + # catch {r geosearch nyc fromlonlat -73.9798091 40.7598464 asc desc withhash withdist withcoord} e + # set e + # } {ERR *exactly one of BYRADIUS and BYBOX*} + + # Pika does not support the command + # test {GEOSEARCH with STOREDIST option} { + # catch {r geosearch nyc fromlonlat -73.9798091 40.7598464 bybox 6 6 km asc storedist} e + # set e + # } {ERR *syntax*} + + test {GEORADIUS withdist (sorted)} { + r georadius nyc -73.9798091 40.7598464 3 km withdist asc + } {{{central park n/q/r} 0.7750} {4545 2.3651} {{union square} 2.7697}} + + # Pika does not support the command + # test {GEOSEARCH withdist (sorted)} { + # r geosearch nyc fromlonlat -73.9798091 40.7598464 bybox 6 6 km withdist asc + # } {{{central park n/q/r} 0.7750} {4545 2.3651} {{union square} 2.7697} {{lic market} 3.1991}} + + test {GEORADIUS with COUNT} { + r georadius nyc -73.9798091 40.7598464 10 km COUNT 3 + } {{central park n/q/r} 4545 {union square}} + + test {GEORADIUS with multiple WITH* tokens} { + assert_match {{{central park n/q/r} 1791875761332224 {-73.97334* 40.76480*}} {4545 1791875796750882 {-73.95641* 40.74809*}}} [r georadius nyc -73.9798091 40.7598464 10 km WITHCOORD WITHHASH COUNT 2] + assert_match {{{central park n/q/r} 1791875761332224 {-73.97334* 40.76480*}} {4545 1791875796750882 {-73.95641* 40.74809*}}} [r georadius nyc -73.9798091 40.7598464 10 km WITHHASH WITHCOORD COUNT 2] + assert_match {{{central park n/q/r} 0.7750 1791875761332224 {-73.97334* 40.76480*}} {4545 2.3651 1791875796750882 {-73.95641* 40.74809*}}} [r georadius nyc -73.9798091 40.7598464 10 km WITHDIST WITHHASH WITHCOORD COUNT 2] + } + + # Pika does not support the command + # test {GEORADIUS with ANY not sorted by default} { + # r georadius nyc -73.9798091 40.7598464 10 km COUNT 3 ANY + # } {{wtc one} {union square} {central park n/q/r}} + + # Pika does not support the command + # test {GEORADIUS with ANY sorted by ASC} { + # r georadius nyc -73.9798091 40.7598464 10 km COUNT 3 ANY ASC + # } {{central park n/q/r} {union square} {wtc one}} + + # Pika does not support the command + # test {GEORADIUS with ANY but no COUNT} { + # catch {r georadius nyc -73.9798091 40.7598464 10 km ANY ASC} e + # set e + # } {ERR *ANY*requires*COUNT*} + + test {GEORADIUS with COUNT but missing integer argument} { + catch {r georadius nyc -73.9798091 40.7598464 10 km COUNT} e + set e + } {ERR *syntax*} + + test {GEORADIUS with COUNT DESC} { + r georadius nyc -73.9798091 40.7598464 10 km COUNT 2 DESC + } {{wtc one} q4} + + test {GEORADIUS HUGE, issue #2767} { + r geoadd users -47.271613776683807 -54.534504198047678 user_000000 + llength [r GEORADIUS users 0 0 50000 km WITHCOORD] + } {1} + + test {GEORADIUSBYMEMBER simple (sorted)} { + r georadiusbymember nyc "wtc one" 7 km + } {{wtc one} {union square} {central park n/q/r} 4545 {lic market}} + + # Pika does not support the command + # test {GEORADIUSBYMEMBER_RO simple (sorted)} { + # r georadiusbymember_ro nyc "wtc one" 7 km + # } {{wtc one} {union square} {central park n/q/r} 4545 {lic market}} + + test {GEORADIUSBYMEMBER search areas contain satisfied points in oblique direction} { + r del k1 + + r geoadd k1 -0.15307903289794921875 85 n1 0.3515625 85.00019260486917005437 n2 + set ret1 [r GEORADIUSBYMEMBER k1 n1 4891.94 m] + assert_equal $ret1 {n1 n2} + + r zrem k1 n1 n2 + r geoadd k1 -4.95211958885192871094 85 n3 11.25 85.0511 n4 + set ret2 [r GEORADIUSBYMEMBER k1 n3 156544 m] + assert_equal $ret2 {n3 n4} + + r zrem k1 n3 n4 + r geoadd k1 -45 65.50900022111811438208 n5 90 85.0511 n6 + set ret3 [r GEORADIUSBYMEMBER k1 n5 5009431 m] + assert_equal $ret3 {n5 n6} + } + + test {GEORADIUSBYMEMBER crossing pole search} { + r del k1 + r geoadd k1 45 65 n1 -135 85.05 n2 + set ret [r GEORADIUSBYMEMBER k1 n1 5009431 m] + assert_equal $ret {n1 n2} + } + + # Pika does not support the command + # test {GEOSEARCH FROMMEMBER simple (sorted)} { + # r geosearch nyc frommember "wtc one" bybox 14 14 km + # } {{wtc one} {union square} {central park n/q/r} 4545 {lic market} q4} + + # No cause has been confirmed + test {GEOSEARCH vs GEORADIUS} { + r del Sicily + r geoadd Sicily 13.361389 38.115556 "Palermo" 15.087269 37.502669 "Catania" + r geoadd Sicily 12.758489 38.788135 "edge1" 17.241510 38.788135 "eage2" + set ret1 [r georadius Sicily 15 37 200 km asc] + assert_equal $ret1 {Catania Palermo} + # Pika does not support the command + # set ret2 [r geosearch Sicily fromlonlat 15 37 bybox 400 400 km asc] + # assert_equal $ret2 {Catania Palermo eage2 edge1} + } + + # Pika does not support the command + # test {GEOSEARCH non square, long and narrow} { + # r del Sicily + # r geoadd Sicily 12.75 36.995 "test1" + # r geoadd Sicily 12.75 36.50 "test2" + # r geoadd Sicily 13.00 36.50 "test3" + # # box height=2km width=400km + # set ret1 [r geosearch Sicily fromlonlat 15 37 bybox 400 2 km] + # assert_equal $ret1 {test1} + + # # Add a western Hemisphere point + # r geoadd Sicily -1 37.00 "test3" + # set ret2 [r geosearch Sicily fromlonlat 15 37 bybox 3000 2 km asc] + # assert_equal $ret2 {test1 test3} + # } + + # Pika does not support the command + # test {GEOSEARCH corner point test} { + # r del Sicily + # r geoadd Sicily 12.758489 38.788135 edge1 17.241510 38.788135 edge2 17.250000 35.202000 edge3 12.750000 35.202000 edge4 12.748489955781654 37 edge5 15 38.798135872540925 edge6 17.251510044218346 37 edge7 15 35.201864127459075 edge8 12.692799634687903 38.798135872540925 corner1 12.692799634687903 38.798135872540925 corner2 17.200560937451133 35.201864127459075 corner3 12.799439062548865 35.201864127459075 corner4 + # set ret [lsort [r geosearch Sicily fromlonlat 15 37 bybox 400 400 km asc]] + # assert_equal $ret {edge1 edge2 edge5 edge7} + # } + + test {GEORADIUSBYMEMBER withdist (sorted)} { + r georadiusbymember nyc "wtc one" 7 km withdist + } {{{wtc one} 0.0000} {{union square} 3.2544} {{central park n/q/r} 6.7000} {4545 6.1975} {{lic market} 6.8969}} + + test {GEOHASH is able to return geohash strings} { + # Example from Wikipedia. + r del points + r geoadd points -5.6 42.6 test + lindex [r geohash points test] 0 + } {ezs42e44yx0} + + test {GEOHASH with only key as argument} { + r del points + r geoadd points 10 20 a 30 40 b + set result [r geohash points] + assert {$result eq {}} + } + + test {GEOPOS simple} { + r del points + r geoadd points 10 20 a 30 40 b + lassign [lindex [r geopos points a b] 0] x1 y1 + lassign [lindex [r geopos points a b] 1] x2 y2 + assert {abs($x1 - 10) < 0.001} + assert {abs($y1 - 20) < 0.001} + assert {abs($x2 - 30) < 0.001} + assert {abs($y2 - 40) < 0.001} + } + + test {GEOPOS missing element} { + r del points + r geoadd points 10 20 a 30 40 b + lindex [r geopos points a x b] 1 + } {} + + test {GEOPOS with only key as argument} { + r del points + r geoadd points 10 20 a 30 40 b + set result [r geopos points] + assert {$result eq {}} + } + + test {GEODIST simple & unit} { + r del points + r geoadd points 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + set m [r geodist points Palermo Catania] + assert {$m > 166274 && $m < 166275} + set km [r geodist points Palermo Catania km] + assert {$km > 166.2 && $km < 166.3} + set dist [r geodist points Palermo Palermo] + assert {$dist eq 0.0000} + } + + test {GEODIST missing elements} { + r del points + r geoadd points 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + set m [r geodist points Palermo Agrigento] + assert {$m eq {}} + set m [r geodist points Ragusa Agrigento] + assert {$m eq {}} + set m [r geodist empty_key Palermo Catania] + assert {$m eq {}} + } + + test {GEORADIUS STORE option: syntax error} { + r del points{t} + r geoadd points{t} 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + catch {r georadius points{t} 13.361389 38.115556 50 km store} e + set e + } {*ERR*syntax*} + + # Pika does not support the command + # test {GEOSEARCHSTORE STORE option: syntax error} { + # catch {r geosearchstore abc{t} points{t} fromlonlat 13.361389 38.115556 byradius 50 km store abc{t}} e + # set e + # } {*ERR*syntax*} + + test {GEORANGE STORE option: incompatible options} { + r del points{t} + r geoadd points{t} 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + catch {r georadius points{t} 13.361389 38.115556 50 km store points2{t} withdist} e + assert_match {*ERR*} $e + catch {r georadius points{t} 13.361389 38.115556 50 km store points2{t} withhash} e + assert_match {*ERR*} $e + catch {r georadius points{t} 13.361389 38.115556 50 km store points2{t} withcoords} e + assert_match {*ERR*} $e + } + + test {GEORANGE STORE option: plain usage} { + r del points{t} + r geoadd points{t} 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + r georadius points{t} 13.361389 38.115556 500 km store points2{t} + assert_equal [r zrange points{t} 0 -1] [r zrange points2{t} 0 -1] + } + + test {GEORADIUSBYMEMBER STORE/STOREDIST option: plain usage} { + r del points{t} + r geoadd points{t} 13.361389 38.115556 "Palermo" 15.087269 37.502669 "Catania" + + r georadiusbymember points{t} Palermo 500 km store points2{t} + assert_equal {Palermo Catania} [r zrange points2{t} 0 -1] + + r georadiusbymember points{t} Catania 500 km storedist points2{t} + assert_equal {Catania Palermo} [r zrange points2{t} 0 -1] + + set res [r zrange points2{t} 0 -1 withscores] + assert {[lindex $res 1] < 1} + assert {[lindex $res 3] > 166} + } + + # Pika does not support the command + # test {GEOSEARCHSTORE STORE option: plain usage} { + # r geosearchstore points2{t} points{t} fromlonlat 13.361389 38.115556 byradius 500 km + # assert_equal [r zrange points{t} 0 -1] [r zrange points2{t} 0 -1] + # } + + test {GEORANGE STOREDIST option: plain usage} { + r del points{t} + r geoadd points{t} 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + r georadius points{t} 13.361389 38.115556 500 km storedist points2{t} + set res [r zrange points2{t} 0 -1 withscores] + assert {[lindex $res 1] < 1} + assert {[lindex $res 3] > 166} + assert {[lindex $res 3] < 167} + } + + # Pika does not support the command + # test {GEOSEARCHSTORE STOREDIST option: plain usage} { + # r geosearchstore points2{t} points{t} fromlonlat 13.361389 38.115556 byradius 500 km storedist + # set res [r zrange points2{t} 0 -1 withscores] + # assert {[lindex $res 1] < 1} + # assert {[lindex $res 3] > 166} + # assert {[lindex $res 3] < 167} + # } + + test {GEORANGE STOREDIST option: COUNT ASC and DESC} { + r del points{t} + r geoadd points{t} 13.361389 38.115556 "Palermo" \ + 15.087269 37.502669 "Catania" + r georadius points{t} 13.361389 38.115556 500 km storedist points2{t} asc count 1 + assert {[r zcard points2{t}] == 1} + set res [r zrange points2{t} 0 -1 withscores] + assert {[lindex $res 0] eq "Palermo"} + + r georadius points{t} 13.361389 38.115556 500 km storedist points2{t} desc count 1 + assert {[r zcard points2{t}] == 1} + set res [r zrange points2{t} 0 -1 withscores] + assert {[lindex $res 0] eq "Catania"} + } + + # Pika does not support the command + # test {GEOSEARCH the box spans -180° or 180°} { + # r del points + # r geoadd points 179.5 36 point1 + # r geoadd points -179.5 36 point2 + # assert_equal {point1 point2} [r geosearch points fromlonlat 179 37 bybox 400 400 km asc] + # assert_equal {point2 point1} [r geosearch points fromlonlat -179 37 bybox 400 400 km asc] + # } + + test {GEOSEARCH with small distance} { + r del points + r geoadd points -122.407107 37.794300 1 + r geoadd points -122.227336 37.794300 2 + assert_equal {{1 0.0001} {2 9.8182}} [r GEORADIUS points -122.407107 37.794300 30 mi ASC WITHDIST] + } + + # Pika does not support the command + # foreach {type} {byradius bybox} { + # test "GEOSEARCH fuzzy test - $type" { + # if {$::accurate} { set attempt 300 } else { set attempt 30 } + # while {[incr attempt -1]} { + # set rv [lindex $regression_vectors $rv_idx] + # incr rv_idx + + # set radius_km 0; set width_km 0; set height_km 0 + # unset -nocomplain debuginfo + # set srand_seed [clock milliseconds] + # if {$rv ne {}} {set srand_seed [lindex $rv 0]} + # lappend debuginfo "srand_seed is $srand_seed" + # expr {srand($srand_seed)} ; # If you need a reproducible run + # r del mypoints + + # if {[randomInt 10] == 0} { + # # From time to time use very big radiuses + # if {$type == "byradius"} { + # set radius_km [expr {[randomInt 5000]+10}] + # } elseif {$type == "bybox"} { + # set width_km [expr {[randomInt 5000]+10}] + # set height_km [expr {[randomInt 5000]+10}] + # } + # } else { + # # Normally use a few - ~200km radiuses to stress + # # test the code the most in edge cases. + # if {$type == "byradius"} { + # set radius_km [expr {[randomInt 200]+10}] + # } elseif {$type == "bybox"} { + # set width_km [expr {[randomInt 200]+10}] + # set height_km [expr {[randomInt 200]+10}] + # } + # } + # if {$rv ne {}} { + # set radius_km [lindex $rv 1] + # set width_km [lindex $rv 1] + # set height_km [lindex $rv 1] + # } + # geo_random_point search_lon search_lat + # if {$rv ne {}} { + # set search_lon [lindex $rv 2] + # set search_lat [lindex $rv 3] + # } + # lappend debuginfo "Search area: $search_lon,$search_lat $radius_km $width_km $height_km km" + # set tcl_result {} + # set argv {} + # for {set j 0} {$j < 20000} {incr j} { + # geo_random_point lon lat + # lappend argv $lon $lat "place:$j" + # if {$type == "byradius"} { + # if {[pointInCircle $radius_km $lon $lat $search_lon $search_lat]} { + # lappend tcl_result "place:$j" + # } + # } elseif {$type == "bybox"} { + # if {[pointInRectangle $width_km $height_km $lon $lat $search_lon $search_lat 1]} { + # lappend tcl_result "place:$j" + # } + # } + # lappend debuginfo "place:$j $lon $lat" + # } + # r geoadd mypoints {*}$argv + # # if {$type == "byradius"} { + # # set res [lsort [r geosearch mypoints fromlonlat $search_lon $search_lat byradius $radius_km km]] + # # } elseif {$type == "bybox"} { + # # set res [lsort [r geosearch mypoints fromlonlat $search_lon $search_lat bybox $width_km $height_km km]] + # # } + # # set res2 [lsort $tcl_result] + # # set test_result OK + + # # if {$res != $res2} { + # # set rounding_errors 0 + # # set diff [compare_lists $res $res2] + # # foreach place $diff { + # # lassign [lindex [r geopos mypoints $place] 0] lon lat + # # set mydist [geo_distance $lon $lat $search_lon $search_lat] + # # set mydist [expr $mydist/1000] + # # if {$type == "byradius"} { + # # if {($mydist / $radius_km) > 0.999} { + # # incr rounding_errors + # # continue + # # } + # # if {$mydist < [expr {$radius_km*1000}]} { + # # # This is a false positive for redis since given the + # # # same points the higher precision calculation provided + # # # by TCL shows the point within range + # # incr rounding_errors + # # continue + # # } + # # } elseif {$type == "bybox"} { + # # # we add 0.1% error for floating point calculation error + # # if {[pointInRectangle $width_km $height_km $lon $lat $search_lon $search_lat 1.001]} { + # # incr rounding_errors + # # continue + # # } + # # } + # # } + + # # # Make sure this is a real error and not a rounidng issue. + # # if {[llength $diff] == $rounding_errors} { + # # set res $res2; # Error silenced + # # } + # # } + + # # if {$res != $res2} { + # # set diff [compare_lists $res $res2] + # # puts "*** Possible problem in GEO radius query ***" + # # puts "Redis: $res" + # # puts "Tcl : $res2" + # # puts "Diff : $diff" + # # puts [join $debuginfo "\n"] + # # foreach place $diff { + # # if {[lsearch -exact $res2 $place] != -1} { + # # set where "(only in Tcl)" + # # } else { + # # set where "(only in Redis)" + # # } + # # lassign [lindex [r geopos mypoints $place] 0] lon lat + # # set mydist [geo_distance $lon $lat $search_lon $search_lat] + # # set mydist [expr $mydist/1000] + # # puts "$place -> [r geopos mypoints $place] $mydist $where" + # # } + # # set test_result FAIL + # # } + # # unset -nocomplain debuginfo + # # if {$test_result ne {OK}} break + # } + # # set test_result + # } {OK} + # } + + # Pika does not support the command + # test {GEOSEARCH box edges fuzzy test} { + # if {$::accurate} { set attempt 300 } else { set attempt 30 } + # while {[incr attempt -1]} { + # unset -nocomplain debuginfo + # set srand_seed [clock milliseconds] + # lappend debuginfo "srand_seed is $srand_seed" + # expr {srand($srand_seed)} ; # If you need a reproducible run + # r del mypoints + + # geo_random_point search_lon search_lat + # set width_m [expr {[randomInt 10000]+10}] + # set height_m [expr {[randomInt 10000]+10}] + # set lat_delta [geo_raddeg [expr {$height_m/2/6372797.560856}]] + # set long_delta_top [geo_raddeg [expr {$width_m/2/6372797.560856/cos([geo_degrad [expr {$search_lat+$lat_delta}]])}]] + # set long_delta_middle [geo_raddeg [expr {$width_m/2/6372797.560856/cos([geo_degrad $search_lat])}]] + # set long_delta_bottom [geo_raddeg [expr {$width_m/2/6372797.560856/cos([geo_degrad [expr {$search_lat-$lat_delta}]])}]] + + # # Total of 8 points are generated, which are located at each vertex and the center of each side + # set points(north) [list $search_lon [expr {$search_lat+$lat_delta}]] + # set points(south) [list $search_lon [expr {$search_lat-$lat_delta}]] + # set points(east) [list [expr {$search_lon+$long_delta_middle}] $search_lat] + # set points(west) [list [expr {$search_lon-$long_delta_middle}] $search_lat] + # set points(north_east) [list [expr {$search_lon+$long_delta_top}] [expr {$search_lat+$lat_delta}]] + # set points(north_west) [list [expr {$search_lon-$long_delta_top}] [expr {$search_lat+$lat_delta}]] + # set points(south_east) [list [expr {$search_lon+$long_delta_bottom}] [expr {$search_lat-$lat_delta}]] + # set points(south_west) [list [expr {$search_lon-$long_delta_bottom}] [expr {$search_lat-$lat_delta}]] + + # lappend debuginfo "Search area: geosearch mypoints fromlonlat $search_lon $search_lat bybox $width_m $height_m m" + # set tcl_result {} + # foreach name [array names points] { + # set x [lindex $points($name) 0] + # set y [lindex $points($name) 1] + # # If longitude crosses -180° or 180°, we need to convert it. + # # latitude doesn't have this problem, because it's scope is -70~70, see geo_random_point + # if {$x > 180} { + # set x [expr {$x-360}] + # } elseif {$x < -180} { + # set x [expr {$x+360}] + # } + # r geoadd mypoints $x $y place:$name + # lappend tcl_result "place:$name" + # lappend debuginfo "geoadd mypoints $x $y place:$name" + # } + + # set res2 [lsort $tcl_result] + + # # make the box larger by two meter in each direction to put the coordinate slightly inside the box. + # set height_new [expr {$height_m+4}] + # set width_new [expr {$width_m+4}] + # set res [lsort [r geosearch mypoints fromlonlat $search_lon $search_lat bybox $width_new $height_new m]] + # if {$res != $res2} { + # set diff [compare_lists $res $res2] + # lappend debuginfo "res: $res, res2: $res2, diff: $diff" + # fail "place should be found, debuginfo: $debuginfo, height_new: $height_new width_new: $width_new" + # } + + # # The width decreases and the height increases. Only north and south are found + # set width_new [expr {$width_m-4}] + # set height_new [expr {$height_m+4}] + # set res [lsort [r geosearch mypoints fromlonlat $search_lon $search_lat bybox $width_new $height_new m]] + # if {$res != {place:north place:south}} { + # lappend debuginfo "res: $res" + # fail "place should not be found, debuginfo: $debuginfo, height_new: $height_new width_new: $width_new" + # } + + # # The width increases and the height decreases. Only ease and west are found + # set width_new [expr {$width_m+4}] + # set height_new [expr {$height_m-4}] + # set res [lsort [r geosearch mypoints fromlonlat $search_lon $search_lat bybox $width_new $height_new m]] + # if {$res != {place:east place:west}} { + # lappend debuginfo "res: $res" + # fail "place should not be found, debuginfo: $debuginfo, height_new: $height_new width_new: $width_new" + # } + + # # make the box smaller by two meter in each direction to put the coordinate slightly outside the box. + # set height_new [expr {$height_m-4}] + # set width_new [expr {$width_m-4}] + # set res [r geosearch mypoints fromlonlat $search_lon $search_lat bybox $width_new $height_new m] + # if {$res != ""} { + # lappend debuginfo "res: $res" + # fail "place should not be found, debuginfo: $debuginfo, height_new: $height_new width_new: $width_new" + # } + # unset -nocomplain debuginfo + # } + # } +} \ No newline at end of file