Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egor batch output when there is a diff is wrong #78

Open
Eroui opened this issue Mar 6, 2021 · 0 comments
Open

Egor batch output when there is a diff is wrong #78

Eroui opened this issue Mar 6, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Eroui
Copy link
Collaborator

Eroui commented Mar 6, 2021

When running an egor batch run and you get a mismatch between the brute-force and the main implementation, the message is not displayed correctly, for example :

❯ egor batch run
Running test 1
Running test 2
Found diff:
Input:
1
6
6 1 5 1 3 4

Expected:
5

Got:
3

Checker failed, token 0 does not match: expected 3, got 5

This is due to the fact that the checker is called with the wrong order of arguments, the checker is expecting to be called check(got, expected) and its actually called check(expected, got)

See https://github.com/chermehdi/go-egor/blob/master/commands/batch.go#L227

@Eroui Eroui added the bug Something isn't working label Mar 6, 2021
@chermehdi chermehdi assigned chermehdi and Eroui and unassigned chermehdi Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants