Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint error W444 (avoid use of tri-state values) in csrng_pkg.sv needs to be cleaned up. A temporary waiver is in place currently. [lowRISC] #696

Open
anjpar opened this issue Jan 17, 2025 · 0 comments

Comments

@anjpar
Copy link
Contributor

anjpar commented Jan 17, 2025

Rebase of caliptra-prim to Earlgrey.PROD_M5 tagged version (PR #685) introduced W444 lint error in csrg_pkg.sv line 32:

typedef enum logic [CSRNG_CMD_STS_WIDTH-1:0] {
CMD_STS_SUCCESS = 'h0,
CMD_STS_INVALID_ACMD = 'h1,
CMD_STS_INVALID_GEN_CMD = 'h2,
CMD_STS_INVALID_CMD_SEQ = 'h3,
CMD_STS_RESEED_CNT_EXCEEDED = 'h4,
CMD_STS_UNDRIVEN = 'z
} csrng_cmd_sts_e;

Error details:


W444 (1 error/0 waived)

Tag : W444
Description : Tristate value '[Value_Name]' specified
Violation : Lint:4
Goal : caliptra_lint_rtl_msft
Module : caliptra_top
FileName : /home/ws/caliptra/anjpar/caliptra_ws_01_06/chipsalliance/caliptra-rtl/src/csrng/rtl/csrng_pkg.sv
LineNumber : 32
Statement : CMD_STS_UNDRIVEN = 'z
Value_Name : 'bzzz

We have a temporary waiver in place, so that we could get past the lint error and push the rebase changes to main.

@anjpar anjpar changed the title Lint error W444 (avoid use of tri-state values) in csrng_pkg.sv needs to be cleaned up. A temporary waiver is in place currently. Lint error W444 (avoid use of tri-state values) in csrng_pkg.sv needs to be cleaned up. A temporary waiver is in place currently. [lowRISC} Jan 17, 2025
@anjpar anjpar changed the title Lint error W444 (avoid use of tri-state values) in csrng_pkg.sv needs to be cleaned up. A temporary waiver is in place currently. [lowRISC} Lint error W444 (avoid use of tri-state values) in csrng_pkg.sv needs to be cleaned up. A temporary waiver is in place currently. [lowRISC] Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant