Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Kill spawned processes (git clone and fetch) if neovim exits #7

Open
xlucn opened this issue Dec 14, 2022 · 0 comments
Open

Kill spawned processes (git clone and fetch) if neovim exits #7

xlucn opened this issue Dec 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@xlucn
Copy link

xlucn commented Dec 14, 2022

I guess vim.loop.spawn does not kill the jobs if neovim is closed, unlike jobstart (I am only sure about jobstart). So when neovim exits, it would be great to clean them up.
@luaneko luaneko added the bug Something isn't working label Dec 20, 2022
xlucn added a commit to xlucn/dep that referenced this issue Dec 24, 2022
@xlucn
replace vim.loop.spawn with vim.fn.jobstart
f6ba5da 
Trying to address chiyadev#7 and chiyadev#9.
`vim.loop.spawn` has two limitations:
- processes does not get killed when exiting neovim
- processes does not inherit neovim's environment variables

`jobstart` happens to workaround these two limitations by default.
@xlucn xlucn mentioned this issue Dec 24, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xlucn @luaneko