Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that 'cluster' is not optional #50

Open
sonyahanson opened this issue Aug 24, 2015 · 2 comments
Open

Note that 'cluster' is not optional #50

sonyahanson opened this issue Aug 24, 2015 · 2 comments

Comments

@sonyahanson
Copy link

Useful to note that ensembler cluster is not optional, even if you know you want to use all your templates.

@jchodera
Copy link
Member

I think you noted that all ensembler steps are obligate? This might be good to document in the manual, and we may want to add pass-through options that allow us to essentially just carry things through to the next stage.

@rafwiewiora
Copy link
Member

Got caught by this!

It seems the issue is ensembler refine_implicit only will refine those models for which unique_by_clustering file exists?

I will update docs ASAP, but also would like to suggest securing this with some exceptions, currently what happened:

  • didn't do ensembler cluster
  • ensembler refine_improper seems to be working ok, before you realize that it should take much longer and print out a a progress message for every model
  • ensembler solvate then doesn't cause an exception, but says No nwaters (...) - and you're not sure what's happening

How about adding something to every command that checks that previous command was called and has completed successfully - I guess by checking for presence for files that were produced by the previous command? So in this case the exception would be thrown when at ensembler refine_implicit no unique_by_clustering files are found. What do you think? @danielparton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants