Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP -- intuitive handling of minimization steps kwarg #1141

Draft
wants to merge 1 commit into
base: 0.10.x
Choose a base branch
from
Draft

WIP -- intuitive handling of minimization steps kwarg #1141

wants to merge 1 commit into from

Conversation

ijpulidos
Copy link
Contributor

Description

More intuitive handling of minimization steps argument minimisation_steps

Motivation and context

minimisation_steps should work like this instead:

  • None should be interpreted to run until tolerance is reached
  • 0 should be interpreted to run 0 steps

Resolves #1086

How has this been tested?

Change log

@ijpulidos
Copy link
Contributor Author

This is still a work in progress. Since this changes the API we need to adapt the tests and examples that are affected by this change.

@mikemhenry mikemhenry changed the base branch from main to 0.10.x July 11, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix feptasks.minimize()'s minimisation_steps argument
1 participant
@ijpulidos