Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor concatenation scripts to make them importable and to give them a CLI #351

Closed
7 tasks done
bcaddy opened this issue Oct 30, 2023 · 1 comment
Closed
7 tasks done
Assignees
Labels
documentation when documentation is incorrect, incomplete, insufficient etc... enhancement refactor for code that is functional but needs to be refactored

Comments

@bcaddy
Copy link
Collaborator

bcaddy commented Oct 30, 2023

It would be nice if all the concatenation scripts could be easily imported into another python script and if they had a CLI for ease of use rather than copying and editing. I've already refactored cat_dset_3d.py and cat_slice.py like this (see PRs #347 and #303) but the others need it too. I'm planning on working on this during our next hack session.

Importable versions already exist in cat.py courtesy of @alwinm, per an offline discussion Alwin and I decided that the method used in cat_slice.py and cat_dset_3d.py is probably better long term so we should update the other scripts to be like them.

  • Refactor cat_dset_3d.py
  • Refactor cat_slice.py
  • Refactor cat_projection.py
  • Refactor cat_particles.py
  • Refactor `cat_rotated_projection.py'
  • Remove cat.py
  • Update documentation at the end of the "Outputs" page in the wiki
@bcaddy bcaddy added enhancement documentation when documentation is incorrect, incomplete, insufficient etc... refactor for code that is functional but needs to be refactored labels Oct 30, 2023
@bcaddy bcaddy self-assigned this Oct 30, 2023
@bcaddy
Copy link
Collaborator Author

bcaddy commented Dec 8, 2023

Resolved in PR #347

@bcaddy bcaddy closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation when documentation is incorrect, incomplete, insufficient etc... enhancement refactor for code that is functional but needs to be refactored
Projects
None yet
Development

No branches or pull requests

1 participant