Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Handling of labels mapping to multiple values in Lexicon fields #749

Open
murphyke opened this issue Dec 3, 2014 · 1 comment
Open

Handling of labels mapping to multiple values in Lexicon fields #749

murphyke opened this issue Dec 3, 2014 · 1 comment

Comments

@murphyke
Copy link
Member

murphyke commented Dec 3, 2014

To what extent should Harvest support Lexicon fields with labels mapping to multiple values, or should this be treated as an error or warning condition (showing up in avocado check, perhaps)?

An example is the Genotype Lexicon from Varify Data Warehouse , which is populated such that two of the labels each map to two values.

Currently what happens depends on whether the field is enumerable or not. If the genotype_id field (vdw.samples.Result) is enumerable, the histogram widget shows a separate entry for each redundant label, and the user doesn't know how to distinguish them. (This is what Varify users experience).

If the field is not enumerable, then just one instance of each redundant label is shown in the search list, which is worse - the user might think she is filtering on all 'Het Ref' genotypes, but in fact is only matching some of them.

It's possible to imagine Harvest automatically translating between a single label and multiple values, but ... should it?

@bruth
Copy link
Contributor

bruth commented Dec 3, 2014

A lexicon should have distinct values with distinct labels. It is up to the maintainer of the lexicon to disambiguate or merge the values in the lexicon itself. On a related note, django-lexicon integration has been removed in Avocado 2.4 since supplementary fields have been introduced.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants