Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound usages of unsafe implementation from Self to T #51

Open
llooFlashooll opened this issue May 26, 2024 · 0 comments
Open

Unsound usages of unsafe implementation from Self to T #51

llooFlashooll opened this issue May 26, 2024 · 0 comments

Comments

@llooFlashooll
Copy link

Hi, I am scanning the anymap in the latest version with my own static analyzer tool.

Unsafe conversion found at: src/any.rs

#[inline]
unsafe fn downcast_ref_unchecked<T: 'static>(&self) -> &T {
    &*(self as *const Self as *const T)
}

#[inline]
unsafe fn downcast_mut_unchecked<T: 'static>(&mut self) -> &mut T {
    &mut *(self as *mut Self as *mut T)
}

#[inline]
unsafe fn downcast_unchecked<T: 'static>(self: Box<Self>) -> Box<T> {
    Box::from_raw(Box::into_raw(self) as *mut T)
}

This unsound implementation would create a misalignment issues, if the generics type T is not properly handled like it's other random types.

This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences. I am reporting this issue for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant