Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End turn hotkey doesn't push the "End turn" button #2

Open
bbuterbrott opened this issue May 9, 2015 · 4 comments
Open

End turn hotkey doesn't push the "End turn" button #2

bbuterbrott opened this issue May 9, 2015 · 4 comments

Comments

@bbuterbrott
Copy link

First, thank you for this hotkeys!
Secondly, when I press end turn hotkey (middle mouse button) I see that the cursor has moved near the button of end turn end clicked, but it was not on top of it so the end turn button is not pushed. Attached a screenshot illustrating the problem (I put a red mark where the cursor was). I am playing in fullscreen mode in 1920x1080 resolution.
hearthstone screenshot 05-09-15 13 41 56

@chrisma
Copy link
Owner

chrisma commented May 9, 2015

Hey,

thanks for the report.
I presume that this is an issue with this particular game board. The script performs edge detection on the green color and a different lighting on the board may influence the color values, leading to an incorrect detection of the "end turn" button location.

Does the script work on other game boards? Do you run the game in windowed or fullscreen mode? Can you try the other mode?

Thanks,
Christoph

@bbuterbrott
Copy link
Author

Hi, Chirstoph!

I will try it today on various boards and windowed and fullscreen modes. The situation from above refers to fullscreen mode.

@bbuterbrott
Copy link
Author

Just played on the same board again. It works for yellow button alright, but for green it only works in windowed mode. In fullscreen mode it, as you described, detects the glowing of the green button, not the button itself.
I will try to fix it.

@bbuterbrott
Copy link
Author

Made a pull request #3 with a fix that is working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants