Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many loading symbols before input #1

Open
chrismeyers opened this issue Feb 17, 2019 · 0 comments
Open

Too many loading symbols before input #1

chrismeyers opened this issue Feb 17, 2019 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@chrismeyers
Copy link
Owner

chrismeyers commented Feb 17, 2019 •
edited
Loading

The number of loading symbols generated is sometimes one greater than expected. This is because the loading thread is sometimes in the middle of a tick when input is requested.

See: pleasehold/core.py::PleaseHold::_loading(), pleasehold/core.py::Transfer::__enter__()
Branch: extra_symbol_before_input
Test: tests/unit/test_input.py
@chrismeyers chrismeyers added bug Something isn't working help wanted Extra attention is needed labels Feb 17, 2019
chrismeyers added a commit that referenced this issue Feb 18, 2019
@chrismeyers
one too many lines were being cleared after input.
e39af55 
This was likely caused by a loading symbol spilling into the first input
prompt (see issue #1).  NOTE: This change prevents empty input prompts,
but there should always be text in a prompt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrismeyers