Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to Tab only on second click #36

Open
falkgeist opened this issue May 14, 2019 · 3 comments
Open

Scroll to Tab only on second click #36

falkgeist opened this issue May 14, 2019 · 3 comments
Assignees
Milestone

Comments

@falkgeist
Copy link

falkgeist commented May 14, 2019

Might be connected to #18

I have a button further up on a onepager (tabs and panes are offpage), linking to a not-active tab with id="reiter-2".

The expected behaviour is, when I click the button, the tab with the id="reiter-2" is set active (=opens) AND scrolls to the pane of that tab.

But at the moment, the first click opens the pane, the second click (when the pane is active) scrolls the view to the pane.

I am not a jquery/mootools/javascript/php professional, only looking at the code every time something doesn't work.

Maybe this is working as intended, but I definitely need the behaviour to work as mentioned. Almost nobody will understand that the first click only opened the pane and just think "the button doesn't work".

Thanks for looking into this.

@falkgeist
Copy link
Author

Running across the issue again, just to see that nothing happened since I opened this issue. Too bad to see that this repository is dead... :(

@christianbarkowsky christianbarkowsky self-assigned this Jul 7, 2020
@christianbarkowsky
Copy link
Owner

This repository is not dead, but other tasks are more important. You can make a pull request. @falkgeist

@falkgeist
Copy link
Author

This repository is not dead

Ah, okay, not dead, very good. :)

but other tasks are more important. You can make a pull request.

Okay, I understand that. Sadly, same here, no time to dive into your code and try to fix it. :( I'll check it out, when I have more time for troubleshooting.

@christianbarkowsky christianbarkowsky added this to the 4.0.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants