Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client shutdown error in master branch #35

Open
arimakai opened this issue Mar 21, 2024 · 0 comments
Open

client shutdown error in master branch #35

arimakai opened this issue Mar 21, 2024 · 0 comments

Comments

@arimakai
Copy link

Dear,
After I run test code from master bran I found error from client side

Traceback (most recent call last):
  File "/home/user/test2.py", line 18, in <module>
    bus.shutdown()
  File "/home/user/env/lib/python3.10/site-packages/can_remote/client.py", line 94, in shutdown
    super().shutdown()
  File "/usr/lib/python3.10/site-packages/can/bus.py", line 414, in shutdown
    self.stop_all_periodic_tasks()
  File "/usr/lib/python3.10/site-packages/can/bus.py", line 299, in stop_all_periodic_tasks
    for task in self._periodic_tasks:
AttributeError: 'RemoteBus' object has no attribute '_periodic_tasks'

Test code copy from readme of this project and I think it come from last commit to add super().shutdown()
Because of RemoteBus class use parent class can.bus.BusABC, I not sure it should be run super().init() or not?
The server.py has not problem because it use instance variable.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant