Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ciaaBAUDRATE_300 to other place #90

Open
mcerdeiro opened this issue Aug 3, 2014 · 5 comments
Open

move ciaaBAUDRATE_300 to other place #90

mcerdeiro opened this issue Aug 3, 2014 · 5 comments
Assignees

Comments

@mcerdeiro
Copy link
Contributor

the definitions of ciaaBAUDRATE_xxxx is performed in https://github.com/ciaa/Firmware/blob/4d5b0c1d298c2242fc104ca1efc32ef85d2239e7/modules/posix/inc/ciaaPOSIX_stdio.h#l144

this shall be improved. this file is for posix implementation and not for data needed for the serial device.

@mcerdeiro mcerdeiro added this to the ciaaFirmware 0.2.1 milestone Aug 3, 2014
@pridolfi
Copy link
Contributor

pridolfi commented Aug 4, 2014

Ok, I put those macros in ...stdio.h because they have to be visible from
user code. @mcerdeiro, where do you suggest to put them instead?

2014-08-03 13:11 GMT-03:00 Mariano Cerdeiro [email protected]:

Assigned #90 #90 to @pridolfi
https://github.com/pridolfi.


Reply to this email directly or view it on GitHub
#90 (comment).

@mcerdeiro
Copy link
Contributor Author

I know why you choose the location. I am thinking about... :) but for sure
not in stdio.h. We may check have is done in linux? but the issue is set
for ciaaFirmware 0.2.1

On Mon, Aug 4, 2014 at 4:06 AM, Pablo Ridolfi [email protected]
wrote:

Ok, I put those macros in ...stdio.h because they have to be visible from
user code. @mcerdeiro, where do you suggest to put them instead?

2014-08-03 13:11 GMT-03:00 Mariano Cerdeiro [email protected]:

Assigned #90 #90 to @pridolfi
https://github.com/pridolfi.


Reply to this email directly or view it on GitHub
#90 (comment).


Reply to this email directly or view it on GitHub
#90 (comment).

@mcerdeiro
Copy link
Contributor Author

is this issue still open? can we close it?

1 similar comment
@mcerdeiro
Copy link
Contributor Author

is this issue still open? can we close it?

@mcerdeiro
Copy link
Contributor Author

issue is still opne. next release.. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants