You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
First of all, thank you for the useful feedback offered in your review. One of the lessons we've learned from the experience of working with your School Lottery project is that in the next release we should make the folder structure imposed by EOSFactory more flexible and configurable.
Apart from the Pull Request, we've created another branch called eosfactory-fix2 in our repository. The goal is to showcase how we imagine EOSFactory to be used with your project.
Firstly, we've moved the Lottery.cpp file to the src folder, as it allows for CMake compatibility.
We recommend having a separate build folder, and execute the build process with CMake:
cd build
cmake ..
make
And then you can run unit tests with CMake:
ctest
Or to make it more verbose:
ctest -V
We find CMake to be extremely convenient and useful.
However, you can still run the tests in the standard way:
python3 test/lottery.spec.py
Please note that we've removed the build process from your unit test. We believe it's better to do the build prior to running unit tests and treat is as a separate activity. That's why we like CMake so much, as it streamlines the whole process and reduces it to just two commands: makeand ctest (you need to run the cmake .. command only once, as all it does is configure the build files).
Also, please note that this branch adds Visual Studio Code compatibility (note the .vscode folder). The benefits of using VSC are desribed here.
And finally, some screenshots showcasing the above recommendations in VSC:
The text was updated successfully, but these errors were encountered:
Hi,
First of all, thank you for the useful feedback offered in your review. One of the lessons we've learned from the experience of working with your School Lottery project is that in the next release we should make the folder structure imposed by EOSFactory more flexible and configurable.
Apart from the Pull Request, we've created another branch called eosfactory-fix2 in our repository. The goal is to showcase how we imagine EOSFactory to be used with your project.
Firstly, we've moved the
Lottery.cpp
file to thesrc
folder, as it allows for CMake compatibility.We recommend having a separate
build
folder, and execute the build process with CMake:And then you can run unit tests with CMake:
Or to make it more verbose:
We find CMake to be extremely convenient and useful.
However, you can still run the tests in the standard way:
Please note that we've removed the build process from your unit test. We believe it's better to do the build prior to running unit tests and treat is as a separate activity. That's why we like CMake so much, as it streamlines the whole process and reduces it to just two commands:
make
andctest
(you need to run thecmake ..
command only once, as all it does is configure the build files).Also, please note that this branch adds Visual Studio Code compatibility (note the
.vscode
folder). The benefits of using VSC are desribed here.And finally, some screenshots showcasing the above recommendations in VSC:
The text was updated successfully, but these errors were encountered: