From 6a21653ef8b27ea9531aea06db5efbed3c1ac66c Mon Sep 17 00:00:00 2001 From: smk762 Date: Fri, 15 Dec 2023 13:50:26 +0800 Subject: [PATCH 1/4] use string literal --- src/core/atomicdex/utilities/global.utilities.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/atomicdex/utilities/global.utilities.cpp b/src/core/atomicdex/utilities/global.utilities.cpp index 7531cb2c17..f11d804164 100644 --- a/src/core/atomicdex/utilities/global.utilities.cpp +++ b/src/core/atomicdex/utilities/global.utilities.cpp @@ -254,10 +254,10 @@ namespace atomic_dex::utils std::string retrieve_main_ticker(const std::string& ticker, const bool segwit_only) { - auto pos = ticker.find('-'); + auto pos = ticker.find("-"); if (segwit_only) { - if (ticker.find('-segwit') != std::string::npos) + if (ticker.find("-segwit") != std::string::npos) { return ticker.substr(0, pos); } From 9c5227e28693edad4574a75d4c7dacccf0bf07c4 Mon Sep 17 00:00:00 2001 From: smk762 Date: Fri, 15 Dec 2023 13:52:17 +0800 Subject: [PATCH 2/4] add return if condition fails --- src/core/atomicdex/models/qt.portfolio.model.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/atomicdex/models/qt.portfolio.model.cpp b/src/core/atomicdex/models/qt.portfolio.model.cpp index c0f8f892eb..269cc78546 100644 --- a/src/core/atomicdex/models/qt.portfolio.model.cpp +++ b/src/core/atomicdex/models/qt.portfolio.model.cpp @@ -408,6 +408,7 @@ namespace atomic_dex { return QString(this->data(res.at(0), BalanceRole).toString()); } + return "0"; } void From 51e23819ea95636a355cf05a2961bf7fc3bb18d0 Mon Sep 17 00:00:00 2001 From: smk762 Date: Fri, 15 Dec 2023 13:56:40 +0800 Subject: [PATCH 3/4] remove unused variables --- src/core/atomicdex/pages/qt.trading.page.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/atomicdex/pages/qt.trading.page.cpp b/src/core/atomicdex/pages/qt.trading.page.cpp index 059e77a9b3..81c02a3106 100644 --- a/src/core/atomicdex/pages/qt.trading.page.cpp +++ b/src/core/atomicdex/pages/qt.trading.page.cpp @@ -1507,8 +1507,6 @@ namespace atomic_dex //! base_min_vol -> 0.0001 KMD //! rel_min_vol -> 10 DOGE t_float_50 min_trade_vol_f = safe_float(min_trade_vol.toStdString()); - const auto& current_min_taker_vol = get_orderbook_wrapper()->get_current_min_taker_vol().toStdString(); - t_float_50 current_min_taker_vol_f = safe_float(current_min_taker_vol); const auto& base_min_taker_vol = get_orderbook_wrapper()->get_base_min_taker_vol().toStdString(); t_float_50 base_min_taker_vol_f = safe_float(base_min_taker_vol); From 1c4e1dfe327d292d223971806bff7cf06e28d459 Mon Sep 17 00:00:00 2001 From: smk762 Date: Fri, 15 Dec 2023 14:00:51 +0800 Subject: [PATCH 4/4] use variable to indicate use of shared function --- src/core/atomicdex/models/qt.orderbook.model.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/atomicdex/models/qt.orderbook.model.cpp b/src/core/atomicdex/models/qt.orderbook.model.cpp index 5e5e09a462..672650894d 100644 --- a/src/core/atomicdex/models/qt.orderbook.model.cpp +++ b/src/core/atomicdex/models/qt.orderbook.model.cpp @@ -524,6 +524,7 @@ namespace atomic_dex void orderbook_model::refresh_orderbook(const t_orders_contents& orderbook, bool is_bestorders) { + SPDLOG_DEBUG("[orderbook_model::refresh_orderbook], is_bestorders: {}", is_bestorders); auto refresh_functor = [this](const std::vector& contents) { for (auto&& order: contents)