You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add UUID to the ScubaResults.json file name, as is done on ScubaGear.
Motivation and context
Consistency with ScubaGear
To ensure each ScubaResults.json has a unique file name.
Implementation notes
Unfortunately, this isn't as straightforward as it could be.
By default, only the first 18 characters of the UUID should be included in the file name. For example: ScubaResults_334a2e69-e073-42ad.json.
The number of characters included in the file name should be configurable. On ScubaGear, there is a "NumberOfUUIDCharactersToTruncate" parameter, which defaults to 18, but accepts the following values:
Care will need to be taken to avoid breaking "cached mode" (see ScubaGoggles parameters runcached and skipexport).
The smoke test will need to be modified to account for this change, including but not limited to:
Documentation will need to be updated giving the info users will need, such as what the new parameter does and what they can expect their output file to be named.
Acceptance criteria
Truncated UUID is included in the ScubaResults*.json file name
The number of characters to truncate is configurable
Cached mode still works
Smoke test still passes
Documentation has been updated to reflect the change
The text was updated successfully, but these errors were encountered:
💡 Summary
Add UUID to the ScubaResults.json file name, as is done on ScubaGear.
Motivation and context
Implementation notes
Unfortunately, this isn't as straightforward as it could be.
ScubaResults_334a2e69-e073-42ad.json
.runcached
andskipexport
).ScubaGoggles/scubagoggles/Testing/Functional/SmokeTests/smoke_test_utils.py
Line 173 in 272a04a
Acceptance criteria
The text was updated successfully, but these errors were encountered: