Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide argument pass-through to packer in the hooks #16

Closed
1 task
mcdonnnj opened this issue Mar 2, 2022 · 2 comments · Fixed by #37
Closed
1 task

Provide argument pass-through to packer in the hooks #16

mcdonnnj opened this issue Mar 2, 2022 · 2 comments · Fixed by #37
Assignees
@mcdonnnj
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Mar 2, 2022

💡 Summary

The hooks in this pre-commit configuration should all argument pass-through to the underlying packer call.

Motivation and context

This feature would allow support for modern configurations by allowing pass-through of build variables and/or passing in a pkrvars file.

Acceptance criteria

How do we know when this work is done?

  • Able to pass command line options through to packer in the hook arguments.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Mar 2, 2022
@mcdonnnj mcdonnnj self-assigned this Mar 2, 2022
@mcdonnnj
Copy link
Member Author

mcdonnnj commented Mar 2, 2022

This encompasses the specifics of #3.

@mcdonnnj mcdonnnj linked a pull request Oct 16, 2024 that will close this issue
Pass arguments to Packer #37
Merged
6 tasks
@mcdonnnj
Copy link
Member Author

This was implemented in a basic manner in #37 and is in the 0.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass arguments to Packer cisagov/pre-commit-packer
1 participant
@mcdonnnj