Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not identify ads on common 18+ sites #5

Open
MovGP0 opened this issue Apr 17, 2017 · 2 comments
Open

does not identify ads on common 18+ sites #5

MovGP0 opened this issue Apr 17, 2017 · 2 comments

Comments

@MovGP0
Copy link

MovGP0 commented Apr 17, 2017

Does not correctly identify ads on 18+ sites like p***hub.com or youp***.com, besides Remove Ads and Ads By ... designations. The HTML even has ad- classes.

@storey
Copy link
Contributor

storey commented Apr 17, 2017

Do these ads include the Adchoices icon
adchoices? The Perceptual Ad Blocker currently finds and highlights advertisements with this icon; any other advertisements will not be blocked. If they do have adchoices icons, please send screenshots. Thanks!

Why don't we block ads, even if they have such obvious class names? The goal is to avoid relying on markup like presence of the "ad-" class, which could be easily changed, and instead to rely on features that are visible to the user (and therefore harder to change), like the Adchoices icon. What this means at the moment is that it does not find non-Adchoices compliant ads.

@MovGP0
Copy link
Author

MovGP0 commented Apr 17, 2017

i understand that the ad-class is not a good choice as a feature of a classifier for the given reasons.

however, the adchoices icon is not available in the majority of ads, so any algorithm that want to identify ads should not rely on them too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants