Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement registerOutParameter in JdbcCallableStatement #29

Open
Tracked by #600
svettwer opened this issue Oct 30, 2018 · 2 comments
Open
Tracked by #600

Implement registerOutParameter in JdbcCallableStatement #29

svettwer opened this issue Oct 30, 2018 · 2 comments
Labels
commissioned An issue whose solution was commissioned by a customer. Prio: Medium TO REVIEW Type: Enhancement
Milestone
v0.2.0

Comments

@svettwer
Copy link
Contributor

svettwer commented Oct 30, 2018 •
edited
Loading

Extracted from citrusframework/citrus#429

User story
As a citrus user, I want to be able to test CallableStatements with OutParameters or InOutParameters so that I'm able to test all of my callable statement implementations.

Additional information
The issue is located in the JdbcCallableStatement within the driver implementation. All out parameter methods are currently not implemented. That's why the parameters are not passed to the server or noted in the requests.
@svettwer svettwer mentioned this issue Jan 24, 2019
Open
4 tasks
@svettwer svettwer added this to the v2.9.0 milestone Jan 24, 2019
svettwer added a commit that referenced this issue Jan 30, 2019
@svettwer
(#29) Added maven release plugin
1ecfe46
svettwer added a commit that referenced this issue Jan 30, 2019
@svettwer
(#29) Set version to 0.2.0-SNAPSHOT
d05243c
svettwer added a commit that referenced this issue Jan 30, 2019
@svettwer
(#29) Added end-2-end test for callable statements with outParameter
d7472e0
svettwer added a commit that referenced this issue Feb 5, 2019
@svettwer
(#29) Improved Demo and E2E-Test
d9811f5
svettwer added a commit that referenced this issue Feb 5, 2019
@svettwer
(#29) Added registerOutParameter and setter implementations
1891b6e
svettwer added a commit that referenced this issue Feb 5, 2019
@svettwer
(#29) Added sonar exclusion for demo project
d297108
svettwer added a commit that referenced this issue Feb 5, 2019
@svettwer
(#29) Added getter Tests
b0dadc7
svettwer added a commit that referenced this issue Feb 5, 2019
@svettwer
(#29) Fixed regression by changing map implementation
5edee36
svettwer added a commit that referenced this issue Feb 7, 2019
@svettwer
(#29) Ensure that getNextRow throws SQLException instead of IndexOutO…
5efc24d 
…fBounds
svettwer added a commit that referenced this issue Feb 7, 2019
@svettwer
(#29) Added type conversion to get Parameters
b0fe29d
svettwer added a commit that referenced this issue Feb 7, 2019
@svettwer
(#29) Added hashCode, equals and toString
f1f2b64
svettwer added a commit that referenced this issue Feb 7, 2019
@svettwer
(#29) Added further getter implementations
4638edf
svettwer added a commit that referenced this issue Feb 7, 2019
@svettwer
(#29) Added some equals and hash code implementations. Removed atomic…
e210cf4 
… integer from equals in DataSet
svettwer added a commit that referenced this issue Feb 7, 2019
@svettwer
(#29) Fixed contract clash between Dataset JdbcCallableStatement
580a16b
@svettwer svettwer mentioned this issue Feb 7, 2019
Merged
svettwer added a commit that referenced this issue Feb 8, 2019
@svettwer
(#29) Fixed plugin versions
9033831
svettwer added a commit that referenced this issue Feb 8, 2019
@svettwer
(#29) Moved responsibility for type conversions to the Row class. Ind…
43317c5 
…ex mapping stays in JdbcCallableStatement
svettwer added a commit that referenced this issue Feb 8, 2019
@svettwer
(#29) Simplified getObject
b07231f
svettwer added a commit that referenced this issue Feb 8, 2019
@svettwer
(#29) Replaced type conversion with conversion by dependency
38593cc
svettwer added a commit that referenced this issue Feb 8, 2019
@svettwer
(#29) Some cleanup
e7fde80
svettwer added a commit that referenced this issue Feb 12, 2019
@svettwer
(#29) Exchanged usage of dataSet with JdbcResultSet in jdbc statement…
ddcc1a3 
…s to encapsulate the dataset properly in a jdbc conform interface
svettwer added a commit that referenced this issue Feb 12, 2019
@svettwer
(#29) simplified test based on data access delegation to JdbcResultSet
9129a33
svettwer added a commit that referenced this issue Feb 12, 2019
@svettwer
(#29) Moved data state from DataSet to JdbcResultSet, added tests to …
e89e103 
…match jdbc contract based on state
svettwer added a commit that referenced this issue Feb 12, 2019
@svettwer
(#29) Fixed issue due to removed exceptions
52cf0e5
svettwer added a commit that referenced this issue Feb 12, 2019
@svettwer
(#29) Added cursor to hash and equals again by accident
8dc69d1
@svettwer
Copy link
Contributor Author

closed by #35

@svettwer
Copy link
Contributor Author

Reopened: We've checked the implementation with the targeted system and found some issues.

@svettwer svettwer reopened this Feb 26, 2019
svettwer added a commit that referenced this issue Feb 26, 2019
@svettwer
(#29) Added exceptions to unsupported getters and setters
cc20a47
svettwer added a commit that referenced this issue Feb 26, 2019
@svettwer
Merge pull request #38 from citrusframework/enhancement/29/addExcepti…
ccb9e36 
…onsToMissingSetters

(#29) Added exceptions to unsupported operations
svettwer added a commit that referenced this issue Mar 5, 2019
@svettwer
(#29) Removed access validation on JdbcResultSet
1412ef2
svettwer added a commit that referenced this issue Mar 5, 2019
@svettwer
(#29) Removed access validation on JdbcResultSet
9fbfe75
svettwer added a commit that referenced this issue Mar 5, 2019
@svettwer
(#29) Removed access validation on JdbcResultSet
893e541
svettwer added a commit that referenced this issue Mar 7, 2019
@svettwer
Merge pull request #40 from citrusframework/enhancement/29/removeAcce…
0f9b31c 
…ssChecks

(#29) Removed access validation
@svettwer svettwer added TO REVIEW and removed READY labels Mar 7, 2019
@svettwer svettwer added the commissioned An issue whose solution was commissioned by a customer. label Aug 5, 2019
svettwer added a commit that referenced this issue Aug 9, 2019
@svettwer
(#29) Compensate to many getNextRow calls on DataSets
85a92bd
svettwer added a commit that referenced this issue Aug 12, 2019
@svettwer
(#29) Preserve data in addition to cursor position
9413d7c
@svettwer svettwer mentioned this issue Aug 12, 2019
Merged
svettwer added a commit that referenced this issue Aug 12, 2019
@svettwer
(#29) improved test case by using test data instead of working on an …
7bd3b07 
…empty DataSet object
svettwer added a commit that referenced this issue Sep 5, 2019
@svettwer
(#29) extracted statement composition and parameter management from j…
b615aef 
…dbc statements
svettwer added a commit that referenced this issue Sep 5, 2019
@svettwer
(#29) changed named parameter expression to math sql standard
1eae951
svettwer added a commit that referenced this issue Sep 5, 2019
@svettwer
(#29) Removed test that makes no sense
e9f933f
svettwer added a commit that referenced this issue Sep 6, 2019
@svettwer
(#29) resolve named and indexed parameters in correct order
05951a7
svettwer added a commit that referenced this issue Sep 6, 2019
@svettwer
(#29) Added StatementParametersTest
ae40c18
svettwer added a commit that referenced this issue Sep 6, 2019
@svettwer
(#29) Added StatementComposerTest
714f779
svettwer added a commit that referenced this issue Sep 6, 2019
@svettwer
(#29) Added parameter placeholder in case no value has been mapped to…
aac411b 
… that parameter
svettwer added a commit that referenced this issue Sep 6, 2019
@svettwer
(#29) Corrected demo calls
0dda9cd
svettwer added a commit that referenced this issue Sep 6, 2019
@svettwer
(#29) fixed sonar exclusion
fa11f4c
svettwer added a commit that referenced this issue Sep 9, 2019
@svettwer
(#29) Added some unit tests
d512a66
svettwer added a commit that referenced this issue Oct 29, 2019
@svettwer
(#29) fixed regression concerning return values of callable statements
4009e70
svettwer added a commit that referenced this issue Oct 29, 2019
@svettwer
Merge pull request #48 from citrusframework/fix/29/callable-statement…
d0b0fa4 
…-regression

(#29) fixed regression concerning return values of callable statements
svettwer added a commit that referenced this issue Oct 30, 2019
@svettwer
(#29)changed first regex group to be non-catching
48ce4ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
commissioned An issue whose solution was commissioned by a customer. Prio: Medium TO REVIEW Type: Enhancement
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@svettwer