From 98f1b0d5a0aacf05d006c19cc4d743a7d3de911b Mon Sep 17 00:00:00 2001 From: Denis Khurtin Date: Wed, 14 Sep 2022 14:26:03 +0300 Subject: [PATCH] Fix sorting in detailed mongodb backup list --- internal/databases/mongo/backup_list_handler.go | 2 +- internal/databases/mongo/binary/backup.go | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/databases/mongo/backup_list_handler.go b/internal/databases/mongo/backup_list_handler.go index 0f25acdb3..599f6cab0 100644 --- a/internal/databases/mongo/backup_list_handler.go +++ b/internal/databases/mongo/backup_list_handler.go @@ -45,7 +45,7 @@ func HandleDetailedBackupList(folder storage.Folder, output io.Writer, pretty, j } sort.Slice(backupDetails, func(i, j int) bool { - return backupDetails[i].FinishLocalTime.After(backupDetails[j].FinishLocalTime) + return backupDetails[i].FinishLocalTime.Before(backupDetails[j].FinishLocalTime) }) switch { diff --git a/internal/databases/mongo/binary/backup.go b/internal/databases/mongo/binary/backup.go index dcd41453f..d5f4d329f 100644 --- a/internal/databases/mongo/binary/backup.go +++ b/internal/databases/mongo/binary/backup.go @@ -62,7 +62,9 @@ func (backupService *BackupService) DoBackup(backupName string, permanent bool) defer func() { if err != nil { closeErr := backupCursor.Close(backupService.Context) - tracelog.ErrorLogger.Printf("Unable to close backup cursor: %+v", closeErr) + if closeErr != nil { + tracelog.ErrorLogger.Printf("Unable to close backup cursor: %+v", closeErr) + } } }()