New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DELETE doesn't propagate the body #225

Open

slinkydeveloper opened this issue Jul 24, 2023 · 1 comment · May be fixed by #226

slinkydeveloper commented Jul 24, 2023

The HTTP DELETE method supports a body, as defined in https://www.rfc-editor.org/rfc/rfc7231#section-4.3.5:

A payload within a DELETE request message has no defined semantics;
sending a payload body on a DELETE request might cause some existing
implementations to reject the request.

But the code generator simply ignores it. It should be easy to fix by changing this line of code: https://github.com/cjbooms/fabrikt/blob/master/src/main/kotlin/com/cjbooms/fabrikt/generators/client/OkHttpSimpleClientGenerator.kt#L212

slinkydeveloper linked a pull request

that will close this issue

Support body on delete requests #226

Open

Author

slinkydeveloper commented Jul 24, 2023

A proposed PR here: #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment