Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom type attribute in scriptLoader method with new parameter #5434

Open
matthandus opened this issue Feb 23, 2023 · 0 comments
Open
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@matthandus
Copy link

Type of report

Feature request

Provide description of the new feature

In the Drupal application, the type attribute is sometimes used to specify the module scope. The script tag that is desired looks like <script src="/path/to/file" type="module"></script>. Currently the CKEDITOR.scriptLoader method adds the default type of 'text/javascript'.

I propose we add another parameter to the scriptLoader method of type string that will render as the value of the type attribute in the script tag that is generated. We can set the type attribute parameter to be a default of 'text/javascript' so backwards compatibility is maintained. With this new feature, we will be able to set the parameter as 'module' when using scriptLoader to set the type attribute in the script tag.

@matthandus matthandus added the type:feature A feature request. label Feb 23, 2023
@Comandeer Comandeer added status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. labels Feb 24, 2023
@ckeditor ckeditor deleted a comment Nov 14, 2023
@ckeditor ckeditor deleted a comment Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Comandeer @matthandus and others