Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the transpileDependencies option in vue.config.js #50

Open
ma2ciek opened this issue Apr 23, 2019 · 5 comments
Open

Reconsider the transpileDependencies option in vue.config.js #50

ma2ciek opened this issue Apr 23, 2019 · 5 comments
Labels
squad:platform Issue to be handled by the Platform team. type:docs

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 23, 2019

This configuration is present here: https://ckeditor.com/docs/ckeditor5/latest/builds/guides/integration/frameworks/vuejs.html#configuring-vueconfigjs

I see two issues with the above configuration:

  1. Should we transpile all CKEditor5 code to ES5? It produces much larger builds and we don't do it by default in our CKEditor 5 builds, it's not mandatory.

  2. The /ckeditor5-[^/\\]+[/\\]src[/\\].+\.js$/ won't match our collaboration repositories, it'd change it to something more like @ckeditor[/\\]ckeditor5?-[^/\\]+[/\\]src[/\\].+\.js$/

@Reinmar Reinmar added this to the iteration 25 milestone Apr 29, 2019
@Reinmar
Copy link
Member

Reinmar commented Jun 26, 2019

  • Should we transpile all CKEditor5 code to ES5? It produces much larger builds and we don't do it by default in our CKEditor 5 builds, it's not mandatory.

Ideally, if we can avoid transpiling that, that'd be best.

2. The /ckeditor5-[^/\\]+[/\\]src[/\\].+\.js$/ won't match our collaboration repositories, it'd change it to something more like @ckeditor[/\\]ckeditor5?-[^/\\]+[/\\]src[/\\].+\.js$/

Can't we simply change ckeditor5- to ckeditor5?-? What other pkg names we have to include besides ckeditor-cloud-services-core?

@mlewand mlewand modified the milestones: iteration 25, iteration 26 Jul 11, 2019
@mlewand mlewand modified the milestones: iteration 26, nice-to-have Jul 29, 2019
@k80oshea
Copy link

I'm running into an issue that I think is related to this when I try to run tests on my Vue project using a customized editor and @ckeditor/ckeditor5-editor-classic. Everything works fine with npm run serve, but on npm run test:unit it does not even run the file anymore after switching from the @ckeditor/ckeditor5-build-classic which had no issues in testing. The error is:

Test suite failed to run
    <project>\node_modules\@ckeditor\ckeditor5-editor-classic\src\classiceditor.js:10
    import Editor from '@ckeditor/ckeditor5-core/src/editor/editor';
           ^^^^^^
    SyntaxError: Unexpected identifier
      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:403:17)

I've got my vue.config.js set up according to the docs, and have tried messing around with the above suggestions and others, also tried some suggested changes for my transform and transformIgnorePatterns in my jest.config.js, but always get the same error.

Has this issue been encountered before?

@rafapaulin
Copy link

a year latter, and there is no solution for this one @k80oshea >.< i am having the same issue.

@rafapaulin
Copy link

still, nothing =/

@JarvisH
Copy link

JarvisH commented Apr 15, 2021

I can confirm this issue, getting the same error using npm run test:unit ... has anybody been able to run tests on a Vue-CLI project with CKeditor being built from source?

Update: Solved this, see #128 (comment)

@Reinmar Reinmar added the squad:platform Issue to be handled by the Platform team. label Oct 28, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:platform Issue to be handled by the Platform team. type:docs
Projects
None yet
Development

No branches or pull requests

8 participants