-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space key not handled in close button #200
Comments
@f1ames could you please review this one? |
A curious thing occurred to me: the listeners that I've been manipulating seem not to be the ones that actually do the job. Investigating now what's happening here. |
There's an issue with this issue, take a look at these two branches: If you comment out the listeners in This could be easily fixed with breaking ecapsulation/separation of concerns by making the My proposition is to implement an "end"(as in: "close AC") event on the |
It looks like a redundant code indeed. But I am not sure if there wasn't a reason for that. I would check to be sure if hiding the balloon panel (that's what happens in the Apart from that, I think the approach with emitting close/end event in |
shift + tab
twice to move the focus on close button.space
.Expected
AC gets closed.
Actual
Key event does not get handled, and default browser behavior apply (scrolling the page).
The text was updated successfully, but these errors were encountered: