-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clSPARSE does not build with OpenCL 2.0 on Debian #162
Comments
We have soft plans to switch the library internals to boost.compute, which will remove references to cl.hpp (see #138). There is no ETA on this though, we only have a proof-of-concept at this point. |
Alright I will hold on then. |
Any news on this? |
The momentum to convert the internals to boost.compute has stopped; we don't have the resources at this time. However, I am working on getting approval to check-in cl.hpp pushed through. |
@pavanky I'll try to find some time to look at this by the end of the week. Cheers for the heads-up. |
I refreshed the packaging with 9677ec3, but cannot get the build to succeed. This is the cmake command run by the package build process:
and the build log output:
|
@ghisvail can you remove explicitly passing |
@pavanky same outcome |
@ghisvail I was able to compile the library with a minor patch after configuring with the following command on debian testing.
|
Thanks for looking at it. Then, it should be fine if we were able to compile, unless you want me to double-check ? |
@ghisvail I sent in this PR: #189 may be wait until it is resolved? Can you also raise a debian bug to update the cl2.hpp header? Khronos moved the headers to a github repo now: https://github.com/KhronosGroup/OpenCL-CLHPP The version available in debian testing is a bit buggy. |
Is the |
@ghisvail This commit seems to be the issue: KhronosGroup/OpenCL-CLHPP@befe77b It was made after the release of 2.0.9. May be you can ask upstream to make a new release? |
I have just sent the bug reports to the Debian maintainers of the OpenCL headers asking for an update. Meanwhile, I'll check with upstream whether they are happy to do a release. Worst case, this commit could be cherry-picked onto |
@pavanky I saw your PR was merged, which means clSPARSE can now probably be built in Debian. Any plans to tag a new release out soon ? |
I can confirm that the current tip of |
My bad. OpenCL 1.2 builds fine, but OpenCL 2.0 still fails. |
You can get a build going with the following patch:
and start a build with OpenCL 2.0, but it leads to more errors:
|
You shouldn't have to change anything.. What is the error you are getting earlier ? |
If you mean cl2.hpp works fine with OpenCL 1.2 I don't see a problem with it. I don't think clSparse has been patched to work in OpenCL 2.0 only. Why do you need to force it to use OpenCL 2.0 APIs ? |
Indeed it works. Will it be sufficient for the next release of ArrayFire then?
That's what I figured from the results of the build above. Seems that the OpenCL 2.0 path of the codebase has not been adapted to recent changes in the API (such as e92f41b). |
ArrayFire also targets 1.2. Considering that OpenCL libraries are backwards compatible, I think that is a fair.
I don't think clSparse ever had an OpenCL 2.0 path. @kknox correct me if I am wrong here. |
Then I'll stick with 1.2 for all clMath libraries to remain consistent with what AF supports.
The official documentation suggests otherwise: "OpenCL 2.0 support is not yet fully implemented; only the interfaces have been designed" |
Using the latest
v0.6.2.0
tag, clSPARSE fails to build on Debian testing / unstable with the following error message:Despite explicitly passing
-DBUILD_CLVERSION=2.0
to CMake.The text was updated successfully, but these errors were encountered: