Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer Initialization in 1D is a Mess #270

Open
mandli opened this issue Jan 18, 2021 · 0 comments
Open

Timer Initialization in 1D is a Mess #270

mandli opened this issue Jan 18, 2021 · 0 comments

Comments

@mandli
Copy link
Member

mandli commented Jan 18, 2021

The function that currently resides in sts1.f looks like

      subroutine initTimers()

      use amr_module
      !implicit double precision (a-h,o-z)

      timeBufnst         = 0
      timeStepgrid       = 0
      timeStepgridCPU    = 0.d0
      timeBound          = 0
      timeBoundCPU       = 0.d0
      timeGrdfitAll      = 0
      timeFlagger        = 0
      timeFlglvl         = 0
      timeFlglvlTot      = 0
      timeGrdfit2        = 0
      timeRegridding     = 0
      timeRegriddingCPU  = 0.d0
      timeTick           = 0
      timeTickCPU        = 0.d0
      timeSetaux         = 0.d0
      timeSetauxCPU      = 0.d0
      timeUpdating       = 0
      timeValout         = 0
      timeValoutCPU      = 0.d0

      return
      end

where these variables are defined in amr_module.f90 as

integer :: timeRegridding, timeUpdating, timeValout
integer :: timeFlglvl,timeGrdfit2,timeGrdfit3,timeGrdfitAll
integer :: timeSetaux,timeFilval,timeBound,timeStepgrid,timeFilvalTot
integer :: timeFlagger, timeBufnst, timeTick, tick_clock_start
real(kind=8) tvollCPU(maxlv), timeTickCPU
real(kind=8) timeBoundCPU,timeStepgridCPU,timeSetauxCPU,timeRegriddingCPU
real(kind=8) timeValoutCPU

The problematic variables are

  • timeSetaux is defined as an integer and initialized as a double. Not entirely bad but not great.
  • timeGrdfit3 is defined but not initialized
  • timeFilvl is defined but not initialized
  • timeFilvalTot is defined but not initialized
  • tick_clock_start is defined but not initialized
  • tvollCPU(maxlv) is defined but not initialized
  • timeFlglvlTot is initialized but not defined
  • timeSetaux is initialized but not defined
    My guess is that some of this is not coming up because these are just timing variables or never used but it would be good to clean this up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant