Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for synching daemon in Zeth CLI #359

Open
AntoineRondelet opened this issue Mar 10, 2021 · 1 comment
Open

Add support for synching daemon in Zeth CLI #359

AntoineRondelet opened this issue Mar 10, 2021 · 1 comment
Labels
autonity-integration Task related to the custom integration of Zeth with Autonity enhancement New feature or request good first issue Good for newcomers python Task related to the Python part of the code base usability Task related to the UX of the project wallet Task related to the wallet implementation

Comments

@AntoineRondelet
Copy link
Contributor

AntoineRondelet commented Mar 10, 2021

It would be useful to extend the zeth sync command with a flag zeth sync --loop (or zeth sync --daemon which would be equivalent to zeth sync --loop &) that would start a process that would constantly sync newly mined blocks.
Such functionalities would be particularly useful when integrating with Autonity (and the current testnet in which blocks are mined at a very fast pace).

@AntoineRondelet AntoineRondelet added enhancement New feature or request good first issue Good for newcomers usability Task related to the UX of the project autonity-integration Task related to the custom integration of Zeth with Autonity python Task related to the Python part of the code base wallet Task related to the wallet implementation labels Mar 10, 2021
@dtebbs
Copy link
Contributor

dtebbs commented May 25, 2021

I hit the same issue of huge numbers of blocks when synching on bakerloo for the first time. With a large --batch-size (~1000000) it syncs quickly enough, but obviously that's not suitable in all situations (for a very busy deployment I guess it could possibly crash the client).

One though I had was that it could be helpful to store some related parameters in the network config file. For example, a default batch size (so that zeth sync always finishes in a reasonable time), or some suitable polling frequency (for the zeth sync daemon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autonity-integration Task related to the custom integration of Zeth with Autonity enhancement New feature or request good first issue Good for newcomers python Task related to the Python part of the code base usability Task related to the UX of the project wallet Task related to the wallet implementation
Projects
None yet
Development

No branches or pull requests

2 participants