-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up #5187
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6aff862 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SignIn/SignUp
SignIn/SignUp
e2e02ec
to
aa2c20a
Compare
59a2b22
to
e836ee1
Compare
62a62ae
to
639e7f8
Compare
755c683
to
4a6e892
Compare
4a6e892
to
a1c1c39
Compare
d27d8c9
to
104791b
Compare
104791b
to
48191f1
Compare
48191f1
to
d74f3e7
Compare
@@ -197,7 +198,7 @@ export interface PublicUserData { | |||
} | |||
|
|||
export interface SessionTask { | |||
key: 'orgs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAPI was previously returning orgs
but it got updated to org
d74f3e7
to
08a8aff
Compare
519759e
to
01b449f
Compare
01b449f
to
e4b54a3
Compare
e4b54a3
to
61dff33
Compare
61dff33
to
a6cfc60
Compare
a6cfc60
to
1328ee2
Compare
1328ee2
to
01855f8
Compare
01855f8
to
b9f8870
Compare
6f6440a
to
0a1d36d
Compare
0a1d36d
to
efed656
Compare
efed656
to
38fbf11
Compare
38fbf11
to
a9de536
Compare
a9de536
to
6aff862
Compare
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
SignIn/SignUp
routesDeveloper flows
For AIO components, it'll work out of the box. Just rendering
<SignIn />
and<SignUp />
will work, since the task gets appended to the routing path and displayed within each component.For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the
OrganizationSwitcher
on the tasks route.Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change