Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tanstack-start): Fix incorrect import in e2e template #5240

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

wobsoriano
Copy link
Member

Description

This PR fixes an incorrect import in the tanstack-start integration template. It was a follow up update to #5234

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: dfa4bee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:40pm

@wobsoriano wobsoriano changed the title fix(tanstack-start): Fix incorrect imports fix(tanstack-start): Fix incorrect import in integration template Feb 26, 2025
@wobsoriano wobsoriano changed the title fix(tanstack-start): Fix incorrect import in integration template fix(tanstack-start): Fix incorrect import in e2e template Feb 26, 2025
@@ -3,9 +3,9 @@ import {
ScrollRestoration,
createRootRoute,
Scripts,
HeadContent,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick follow up commit to #5234 which has an incorrect import

@wobsoriano wobsoriano marked this pull request as ready for review February 26, 2025 18:39
@wobsoriano wobsoriano changed the title fix(tanstack-start): Fix incorrect import in e2e template fix(integration): Fix incorrect import in e2e template Feb 26, 2025
@wobsoriano wobsoriano changed the title fix(integration): Fix incorrect import in e2e template fix(integration): Fix incorrect import in TanStack Start e2e template Feb 26, 2025
@wobsoriano wobsoriano changed the title fix(integration): Fix incorrect import in TanStack Start e2e template test(tanstack-start): Fix incorrect import in TanStack Start e2e template Feb 26, 2025
@wobsoriano wobsoriano changed the title test(tanstack-start): Fix incorrect import in TanStack Start e2e template test(tanstack-start): Fix incorrect import in e2e template Feb 26, 2025
@wobsoriano wobsoriano requested a review from brkalow February 26, 2025 18:45
@wobsoriano wobsoriano merged commit 3dbdde1 into main Feb 26, 2025
34 of 37 checks passed
@wobsoriano wobsoriano deleted the rob/fix-tanstack-start-e2e branch February 26, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants