Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunks are cached forever by default #4

Open
niran opened this issue Feb 16, 2011 · 1 comment
Open

Chunks are cached forever by default #4

niran opened this issue Feb 16, 2011 · 1 comment

Comments

@niran
Copy link

niran commented Feb 16, 2011

If you don't pass a cache timeout to {% chunk %}, the chunk contents will be cached forever (or until the cache runs out of space). I can't see how this would ever be desirable behavior. The chunk is being stored in the database so it can be modified at will, yet the default behavior prevents that from taking effect. I'd recommend merging in carljm/django-chunks@8dcf287e to rip out the caching support altogether. Users who want to cache the chunk can wrap it in {% cache %}.

Alternatively, the Chunk model should clear the cached value on save.

@JoeJasinski
Copy link

I'm working on a fix to clear each cache key on save. I need to test still. My work can be found here.

https://github.com/imagescape/django-chunks/tree/develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants