Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace content fails on Windows #41

Open
skrat opened this issue Nov 17, 2016 · 2 comments
Open

Replace content fails on Windows #41

skrat opened this issue Nov 17, 2016 · 2 comments
Labels

Comments

@skrat
Copy link

skrat commented Nov 17, 2016

This boot file

https://github.com/skrat/packages/blob/facb55a73efa7f8db6b0daf1536699071a1cafe4/libtess/build.boot

Throws this error on Windows (but works on Linux)

https://gist.github.com/skrat/79b7e43899e685a35dcecd70cd4d1bf5

According to @micha , the bug is here

https://github.com/cljsjs/boot-cljsjs/blob/0.5.2/src/cljsjs/boot_cljsjs/packaging.clj#L179

@skrat
Copy link
Author

skrat commented Nov 17, 2016

Perhaps we shouldn't be using the in string as a regex, because of the different path delimiter on different platforms.

@skrat
Copy link
Author

skrat commented Nov 18, 2016

Another option is to have, and use, a function that transforms path regexes into platform agnostic ones, ie. replace / with /|\\

@Deraen Deraen added the windows label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants