Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the spacetimedb-quickstart and spacetimedb-quickstart-cs modules #2155

Open
cloutiertyler opened this issue Jan 21, 2025 · 1 comment
Assignees

Comments

@cloutiertyler
Copy link
Contributor

cloutiertyler commented Jan 21, 2025

https://github.com/clockworklabs/SpacetimeDB/tree/master/modules/spacetimedb-quickstart
AND
https://github.com/clockworklabs/SpacetimeDB/tree/master/modules/spacetimedb-quickstart-cs

serve an unclear purpose. In the interest of clearly defining support and testing requirements, I propose that we rename these modules to:

module-test-rs
AND
module-test-cs

Additionally the code from rust-wasm-test should be transferred verbatim (or as near to verbatim as is possible, lest we have a regression) into module-test-rs and translated into module-test-cs.

rust-wasm-test should then be removed.

@cloutiertyler cloutiertyler changed the title Remove the spacetimedb-quickstart and spacetimedb-quickstart-cs modules (but replace tests) Rename the spacetimedb-quickstart and spacetimedb-quickstart-cs modules Jan 21, 2025
@bfops
Copy link
Collaborator

bfops commented Jan 27, 2025

I agree with the goal here, but it seems not-blocking for 1.0 release? Couldn't this be a priority for our testing pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants