From 82c6dd87bf91c2a39dce15a77fa9462af7ff036a Mon Sep 17 00:00:00 2001
From: Victor Berchet <victor@suumit.com>
Date: Sat, 1 Feb 2025 08:15:56 +0100
Subject: [PATCH] Use builtin implementation for isArray and isDeepStrictEqual

---
 .changeset/lazy-windows-provide.md             |  5 +++++
 .../src/runtime/node/util/index.ts             | 18 ++++++++----------
 packages/unenv-preset/tests/worker/index.ts    |  5 ++++-
 3 files changed, 17 insertions(+), 11 deletions(-)
 create mode 100644 .changeset/lazy-windows-provide.md

diff --git a/.changeset/lazy-windows-provide.md b/.changeset/lazy-windows-provide.md
new file mode 100644
index 000000000000..4603d79a4645
--- /dev/null
+++ b/.changeset/lazy-windows-provide.md
@@ -0,0 +1,5 @@
+---
+"@cloudflare/unenv-preset": patch
+---
+
+Use builtin implementation for isArray and isDeepStrictEqual
diff --git a/packages/unenv-preset/src/runtime/node/util/index.ts b/packages/unenv-preset/src/runtime/node/util/index.ts
index a814ec5c814c..9c050d2d7479 100644
--- a/packages/unenv-preset/src/runtime/node/util/index.ts
+++ b/packages/unenv-preset/src/runtime/node/util/index.ts
@@ -4,11 +4,9 @@ import {
 	_exceptionWithHostPort,
 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,
 	isBoolean,
 	isBuffer,
 	isDate,
-	isDeepStrictEqual,
 	isError,
 	isFunction,
 	isNull,
@@ -30,11 +28,9 @@ export {
 	_exceptionWithHostPort,
 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,
 	isBoolean,
 	isBuffer,
 	isDate,
-	isDeepStrictEqual,
 	isError,
 	isFunction,
 	isNull,
@@ -71,6 +67,8 @@ export const {
 	getCallSite,
 	inherits,
 	inspect,
+	isArray,
+	isDeepStrictEqual,
 	log,
 	parseArgs,
 	promisify,
@@ -91,11 +89,9 @@ export default {
 	_exceptionWithHostPort,
 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,
 	isBoolean,
 	isBuffer,
 	isDate,
-	isDeepStrictEqual,
 	isError,
 	isFunction,
 	isNull,
@@ -113,10 +109,6 @@ export default {
 	/**
 	 * manually unroll workerd-polyfilled-symbols to make it tree-shakeable
 	 */
-	MIMEParams,
-	MIMEType,
-	TextDecoder,
-	TextEncoder,
 	_extend,
 	aborted,
 	callbackify,
@@ -128,10 +120,16 @@ export default {
 	getCallSite,
 	inherits,
 	inspect,
+	isArray,
+	isDeepStrictEqual,
 	log,
+	MIMEParams,
+	MIMEType,
 	parseArgs,
 	promisify,
 	stripVTControlCharacters,
+	TextDecoder,
+	TextEncoder,
 	toUSVString,
 	transferableAbortController,
 	transferableAbortSignal,
diff --git a/packages/unenv-preset/tests/worker/index.ts b/packages/unenv-preset/tests/worker/index.ts
index 44926d0fd5c6..92dba0177d94 100644
--- a/packages/unenv-preset/tests/worker/index.ts
+++ b/packages/unenv-preset/tests/worker/index.ts
@@ -109,9 +109,12 @@ async function testNodeCompatModules() {
 }
 
 async function testUtilImplements() {
-	const { types } = await import("node:util");
+	const util = await import("node:util");
+	const { types } = util;
 	assert.strictEqual(types.isExternal("hello world"), false);
 	assert.strictEqual(types.isAnyArrayBuffer(new ArrayBuffer(0)), true);
+	assert.strictEqual(util.isArray([]), true);
+	assert.strictEqual(util.isDeepStrictEqual(0, 0), true);
 }
 
 async function testPath() {