Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] expose the metadata from ESBuild bundling? #7877

Closed
vicb opened this issue Jan 23, 2025 · 3 comments
Closed

[Feature] expose the metadata from ESBuild bundling? #7877

vicb opened this issue Jan 23, 2025 · 3 comments
Assignees

Comments

@vicb
Copy link
Contributor

vicb commented Jan 23, 2025

It would be quite helpful for the OpenNext adapter to have access to the metadata of the ESBuild bundling.
It would allow checking what input files are included and there size (i.e. https://esbuild.github.io/api/#analyze)

We do already generate those metadata during the build but don't dump them to the disk.
I think we could generate an optional <bundle.js>.metafile.json on wrangler deploy --dry-run --outfile

Do you think it's worth it?
If yes, I see 2 options: via an env var (i.e. WRANGLER_GENERATE_METAFILE) or via a --metafile option.

Thoughts?

/cc @petebacondarwin @dario-piotrowicz

related: #7876

@vicb
Copy link
Contributor Author

vicb commented Jan 24, 2025

@petebacondarwin I re-assigned this to me. My intention was to work on this from the beginning, I only assigned to you as I had questions about how to activate this... but realized it might be confusing :)

@penalosa
Copy link
Contributor

I think this is a duplicate of #4633?

@vicb
Copy link
Contributor Author

vicb commented Jan 29, 2025

Thanks for noticing @penalosa, closing as duplicate!

@vicb vicb closed this as completed Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants