bad value on node for label kubernetes-io/hostname in case of openstack

[obeyler]

What happened:
kubernetes.io/hostname label of node is set to Ip adress instead of hostname

on K8S doc they say that the normal behavior is to put hostname :
https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/#kubernetes-io-hostname
some product such as OpenEBS use this label as node selector so they are not able to select the right node

Node-Selectors: kubernetes.io/hostname=vm-7ea13877-8947-476f-a125-b642ee34fbc0

What you expected to happen:
put the hostname and not the Ip as value of kubernetes.io/hostname

Anything else we need to know?:
I think that the trouble is located there :

kubo-release/jobs/kubelet/templates/bin/kubelet_ctl.erb

Lines 83 to 92 in 3d1cefe

	get_hostname_override() {
	if [[ "gce" == "$cloud_provider" ]]; then
	hostname_override=$(curl http://metadata.google.internal/computeMetadata/v1/instance/name -H "Metadata-Flavor: Google")
	elif [[ "azure" == "$cloud_provider" ]]; then
	# K8s 1.9 Azure provider assumes the hostname == nodename and is required to resolve the VM instance ID
	hostname_override=
	else
	hostname_override=<%= spec.ip %>
	fi

on openstack we can get the hostname of the iaas vm by this way:

VAR=$(curl http://169.254.169.254/2009-04-04/meta-data/hostname)
hostname_override=${VAR%.novalocal}

and may another good/best solution is to allow as an option to set it to the result of hostname linux command of the vm (witch is also another value)

Environment:

• Deployment Info (bosh -d <deployment> deployment): cfcr-34
• Environment Info (bosh -e <environment> environment):
• Kubernetes version (kubectl version): 1.14.1
• Cloud provider (e.g. aws, gcp, vsphere): openstack