Stop assigning VIPs to internal routes

[tcdowney]

This is a tech-debt issue and low priority. I'm mostly logging it so that we can capture the fact that this is dead code.

Issue

Cloud Controller is assigning virtual IP addresses to internal routes. This was added to support internal "service mesh" domains using Istio, but the experimental Istio support has long since been deprecated:

• https://github.com/cloudfoundry-attic/istio-release#deprecated
• Disconnect the Istio Copilot Adapter #2942

This code occasionally causes bugs, so removing it could reduce the long term maintenance costs of Cloud Controller.

Context

These VIPs were sent along as part of the route definition to Istio Copilot.

The current container-to-container (c2c) networking system does not make use of these VIPs and they're otherwise ignored by the platform.

Steps to Reproduce

Nothing to reproduce, just dead code. The A/C for this would be to remove the VIP-related code from CCNG and capi-release, deploy, and then confirm that internal c2c routing continues to work.

Possible Fix

Remove VIP related code from the Route model in Cloud Controller and then remove vip_range related properties and templating from capi-release.

https://github.com/search?q=repo%3Acloudfoundry%2Fcapi-release+vip_range&type=code