-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a Korifi operator I want to be able to enable experimental managed services support #3262
Labels
Comments
danail-branekov
added a commit
that referenced
this issue
May 31, 2024
The upcoming managed services support would be initially disabled by setting the helm value to `false` (the default) Operators should deliberately enable the flag should they want to give the feature a try. This change simply introduces the flag in the helm chart, there is no implementation that uses it yet. The `deploy-on-kind` script sets it to `true` as it is meant to be run for development purposes. The kind installer sets it to `true` as well - whoever is installing Korifi on kind probably just wants to play with it, therefore enabling the experimental support does make sense. fixes #3262
danail-branekov
added a commit
that referenced
this issue
Jun 4, 2024
The upcoming managed services support would be initially disabled by setting the helm value to `false` (the default) Operators should deliberately enable the flag should they want to give the feature a try. This change simply introduces the flag in the helm chart, there is no implementation that uses it yet. The `deploy-on-kind` script sets it to `true` as it is meant to be run for development purposes. The kind installer sets it to `true` as well - whoever is installing Korifi on kind probably just wants to play with it, therefore enabling the experimental support does make sense. fixes #3262
danail-branekov
added a commit
that referenced
this issue
Jun 5, 2024
The upcoming managed services support would be initially disabled by setting the helm value to `false` (the default) Operators should deliberately enable the flag should they want to give the feature a try. This change simply introduces the flag in the helm chart, there is no implementation that uses it yet. The `deploy-on-kind` script sets it to `true` as it is meant to be run for development purposes. The kind installer sets it to `true` as well - whoever is installing Korifi on kind probably just wants to play with it, therefore enabling the experimental support does make sense. fixes #3262
danail-branekov
added a commit
that referenced
this issue
Jun 6, 2024
The upcoming managed services support would be initially disabled by setting the helm value to `false` (the default) Operators should deliberately enable the flag should they want to give the feature a try. This change simply introduces the flag in the helm chart, there is no implementation that uses it yet. The `deploy-on-kind` script sets it to `true` as it is meant to be run for development purposes. The kind installer sets it to `true` as well - whoever is installing Korifi on kind probably just wants to play with it, therefore enabling the experimental support does make sense. fixes #3262
danail-branekov
added a commit
to cloudfoundry/korifi-ci
that referenced
this issue
Jun 10, 2024
danail-branekov
added a commit
that referenced
this issue
Jun 10, 2024
The upcoming managed services support would be initially disabled by setting the helm value to `false` (the default) Operators should deliberately enable the flag should they want to give the feature a try. This change simply introduces the flag in the helm chart, there is no implementation that uses it yet. The `deploy-on-kind` script sets it to `true` as it is meant to be run for development purposes. The kind installer sets it to `true` as well - whoever is installing Korifi on kind probably just wants to play with it, therefore enabling the experimental support does make sense. fixes #3262
github-project-automation
bot
moved this from 🔄 In progress
to ✅ Done
in Korifi - Backlog
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
GIVEN I use the default helm values
WHEN I install the Korifi helm chart
THEN I can see the
experimentalManagedServicesEnabled
set tofalse
in both api and controllers config mapsGIVEN I have specified the
experimental.managed-services-enabled=true
in my helm valuesWHEN I install the Korifi helm chart
THEN I can see the
experimentalManagedServicesEnabled
set totrue
in both api and controllers config mapsThe text was updated successfully, but these errors were encountered: