Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Korifi operator I want to be able to enable experimental managed services support #3262

Closed
danail-branekov opened this issue May 22, 2024 · 0 comments
Assignees

Comments

@danail-branekov
Copy link
Member

GIVEN I use the default helm values
WHEN I install the Korifi helm chart
THEN I can see the experimentalManagedServicesEnabled set to false in both api and controllers config maps

GIVEN I have specified the experimental.managed-services-enabled=true in my helm values
WHEN I install the Korifi helm chart
THEN I can see the experimentalManagedServicesEnabled set to true in both api and controllers config maps

@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog May 22, 2024
@danail-branekov danail-branekov moved this from 🧊 Icebox to 🇪🇺 To do in Korifi - Backlog May 31, 2024
@danail-branekov danail-branekov moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog May 31, 2024
@danail-branekov danail-branekov self-assigned this May 31, 2024
danail-branekov added a commit that referenced this issue May 31, 2024
The upcoming managed services support would be initially disabled by
setting the helm value to `false` (the default)

Operators should deliberately enable the flag should they want to give
the feature a try.

This change simply introduces the flag in the helm chart, there is no
implementation that uses it yet. The `deploy-on-kind` script sets it to
`true` as it is meant to be run for development purposes.

The kind installer sets it to `true` as well - whoever is installing
Korifi on kind probably just wants to play with it, therefore enabling
the experimental support does make sense.

fixes #3262
danail-branekov added a commit that referenced this issue Jun 4, 2024
The upcoming managed services support would be initially disabled by
setting the helm value to `false` (the default)

Operators should deliberately enable the flag should they want to give
the feature a try.

This change simply introduces the flag in the helm chart, there is no
implementation that uses it yet. The `deploy-on-kind` script sets it to
`true` as it is meant to be run for development purposes.

The kind installer sets it to `true` as well - whoever is installing
Korifi on kind probably just wants to play with it, therefore enabling
the experimental support does make sense.

fixes #3262
danail-branekov added a commit that referenced this issue Jun 5, 2024
The upcoming managed services support would be initially disabled by
setting the helm value to `false` (the default)

Operators should deliberately enable the flag should they want to give
the feature a try.

This change simply introduces the flag in the helm chart, there is no
implementation that uses it yet. The `deploy-on-kind` script sets it to
`true` as it is meant to be run for development purposes.

The kind installer sets it to `true` as well - whoever is installing
Korifi on kind probably just wants to play with it, therefore enabling
the experimental support does make sense.

fixes #3262
danail-branekov added a commit that referenced this issue Jun 6, 2024
The upcoming managed services support would be initially disabled by
setting the helm value to `false` (the default)

Operators should deliberately enable the flag should they want to give
the feature a try.

This change simply introduces the flag in the helm chart, there is no
implementation that uses it yet. The `deploy-on-kind` script sets it to
`true` as it is meant to be run for development purposes.

The kind installer sets it to `true` as well - whoever is installing
Korifi on kind probably just wants to play with it, therefore enabling
the experimental support does make sense.

fixes #3262
danail-branekov added a commit to cloudfoundry/korifi-ci that referenced this issue Jun 10, 2024
danail-branekov added a commit that referenced this issue Jun 10, 2024
The upcoming managed services support would be initially disabled by
setting the helm value to `false` (the default)

Operators should deliberately enable the flag should they want to give
the feature a try.

This change simply introduces the flag in the helm chart, there is no
implementation that uses it yet. The `deploy-on-kind` script sets it to
`true` as it is meant to be run for development purposes.

The kind installer sets it to `true` as well - whoever is installing
Korifi on kind probably just wants to play with it, therefore enabling
the experimental support does make sense.

fixes #3262
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant