Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RBAC usage optional for use with extension API server #3670

Open
c0d1ngm0nk3y opened this issue Dec 19, 2024 · 2 comments
Open

Make RBAC usage optional for use with extension API server #3670

c0d1ngm0nk3y opened this issue Dec 19, 2024 · 2 comments
Labels

Comments

@c0d1ngm0nk3y
Copy link
Contributor

c0d1ngm0nk3y commented Dec 19, 2024

Description

Korifi levereges RBAC to implement authorization (e. what apps are visible to a certain user). Since Korifi is currently interacting directly with RoleBinding this is currently fix.

If would be great to give the option to install Korifi without the use of RBAC. The authorization would not work out of the box, but has to be provided differently, similar to extenting Korifi via AppWorkload or BuildWorkload.

The use case I have in mind is an extension API server. If someone implements an extension API server, it could also do the permission check and therefor the RBAC overhead would not be needed.

This touches a few things:

  • Introduction of a CFRole to allow the extension server to get all permissions. So not creating RoleBindings directly
  • space_filtering_client will not be used for any repository. Rather than checking all namespaces, korifi could jetzt request everything from the API server and the extension API server will only return the objects the user has permissions
  • The logic to check if the current user is a cf_user would probably be different.
@c0d1ngm0nk3y
Copy link
Contributor Author

Now with the space_filtering_client that should even be more straight forward since already all object are selected and the label selector ensures to select only the one with access to. We sould without RBAC just skip the label selector since the calculation on the label could get expensive for many spaces and users.

@c0d1ngm0nk3y
Copy link
Contributor Author

@cloudfoundry/wg-cf-on-k8s-korifi-approvers Would you take contributions towards this epic?

@c0d1ngm0nk3y c0d1ngm0nk3y changed the title Make RBAC usage optional Make RBAC usage optional for use with extension API server Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Draft
Development

No branches or pull requests

1 participant