Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployments of optional components #3740

Closed
uzabanov opened this issue Jan 21, 2025 · 0 comments
Closed

Improve deployments of optional components #3740

uzabanov opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels

Comments

@uzabanov
Copy link
Contributor

Background

With Korifi 0.14 we have introduced deployment per every optional component (statefulset runner, kpack image builder, job task runner). The names of their deployments are not prefixed with korifi- (as api and controllers are):

0|0 ❯ k -n korifi get deployments
NAME                                     READY   UP-TO-DATE   AVAILABLE   AGE
job-task-runner-controller-manager       1/1     1            1           5m13s
korifi-api-deployment                    1/1     1            1           5m13s
korifi-controllers-controller-manager    1/1     1            1           5m13s
kpack-image-builder-controller-manager   1/1     1            1           5m13s
statefulset-runner-controller-manager    1/1     1            1           5m13s

Same goes for their pods:

❯❯ k -n korifi get pods
NAME                                                      READY   STATUS    RESTARTS   AGE
job-task-runner-controller-manager-7687cc455f-q455w       1/1     Running   0          5m42s
korifi-api-deployment-7788dc6dc4-fhkqg                    1/1     Running   0          5m42s
korifi-controllers-controller-manager-647c5bd889-v5pt9    1/1     Running   0          5m42s
kpack-image-builder-controller-manager-586cf769bf-w7v4v   1/1     Running   0          5m42s
statefulset-runner-controller-manager-7576cb899c-nmqgp    1/1     Running   0          5m42s

Also, logs for the optional components do not start with the Korifi version (as logs for api and controllers do)

Action to take:

  • Prefix the name of the deployments with korifi-
  • Prefix the name of deplotment pods with korifi-
  • Fix optional components logs to specify Korifi version (see this example)
@uzabanov uzabanov added the chore label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Jan 21, 2025
@danail-branekov danail-branekov moved this from 🧊 Icebox to 🔄 In progress in Korifi - Backlog Jan 21, 2025
uzabanov added a commit that referenced this issue Jan 21, 2025
georgethebeatle added a commit that referenced this issue Jan 22, 2025
fixes #3740

Co-authored-by: Yusmen Zabanov <[email protected]>
Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle added a commit that referenced this issue Jan 22, 2025
fixes #3740

Co-authored-by: Yusmen Zabanov <[email protected]>
Co-authored-by: Georgi Sabev <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants