Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a Korifi user I want to be able to configure a custom log-cache imelementation #3754

Closed
georgethebeatle opened this issue Jan 24, 2025 · 0 comments
Closed

As a Korifi user I want to be able to configure a custom log-cache imelementation #3754

georgethebeatle opened this issue Jan 24, 2025 · 0 comments
Assignees
@danail-branekov @uzabanov
Labels
Basic System Observability
Milestone
release-candidate

Comments

@georgethebeatle
Copy link
Member

georgethebeatle commented Jan 24, 2025 •
edited
Loading

Background

After #3752 exports app/process metrics to the /api/v1/read endpoint we are ready to make the log cache url configurable, so that our users can plug in an expternal log cache implementation

Acceptance

GIVEN I deploy Korifi with the new experimental.externalLogCache.enabled=true and experimental.externalLogCache.url=<some-url> helm values
WHEN I run cf push --verbose
THEN I can see in the verbose logs that the cf cli is indeed requesting the url provided by the helm values

WHEN I run cf curl /api/v1/read
THEN I get a 404 NotFound

WHEN I runcf curl /
THEN I see that the external log cach is advertised
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Jan 24, 2025
@georgethebeatle georgethebeatle moved this from 🧊 Icebox to 🇪🇺 To do in Korifi - Backlog Jan 24, 2025
@georgethebeatle georgethebeatle added this to the release-candidate milestone Jan 24, 2025
@danail-branekov danail-branekov moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Feb 11, 2025
@danail-branekov danail-branekov moved this from 🔄 In progress to 🇪🇺 To do in Korifi - Backlog Feb 11, 2025
@danail-branekov danail-branekov moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Feb 17, 2025
danail-branekov added a commit that referenced this issue Feb 17, 2025
@danail-branekov @uzabanov
Introduce experimental.externalLogCache helm values

Verified

This commit was signed with the committer’s verified signature.
sergio-costas Sergio Costas
GPG key ID: D4A5410CE1372A40
Verified
Learn about vigilant mode
Loading
Loading status checks…
1edcf74 
fixes #3754

Co-authored-by: Danail Branekov <[email protected]>
Co-authored-by: Yusmen Zabanov <[email protected]>
@danail-branekov danail-branekov mentioned this issue Feb 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danail-branekov danail-branekov

@uzabanov uzabanov

Labels
Basic System Observability
Projects
Korifi - Backlog
Status: ✅ Done
Milestone
release-candidate
Development

No branches or pull requests
3 participants
@danail-branekov @georgethebeatle @uzabanov