Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume insecure ssl communication with the naive logcache implementation #3812

Open
georgethebeatle opened this issue Feb 17, 2025 · 1 comment

Comments

@georgethebeatle
Copy link
Member

Background

Today the naive logcache implementation of Korifi lives alongside all other CF v3 API handlers. This is confusing as the logcache endpoints are not a part of the CF API. With the most recent developments around using logcache for fetching not only logs, but also metrics, things become slightly more involved.

On the one hand the cf cli needs to be able to reach the logcahe from outside of the cluster (via ingress). On the other, the CF v3 implementation needs to be able to reach the same api endpoint from the inside. This is not a problem for real clusters, but it is a challenge on kind, where the ingress essentially resolves to localhost.

Action to take

  • Explore the possibilities of hitting the same url both from the outside and from the inside.
    • We could exploit the knowledge that the logcache runs on the same host as the CF v3, but this means its certificate will have to be valid both for the ingress and the internal dns service
    • Use the "kind" docker network hostname for internal communication. This might be problematic on mac, since docker is running in a VM and not directly on the host.
    • Do something else
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Feb 17, 2025
@georgethebeatle georgethebeatle moved this from 🧊 Icebox to 🇪🇺 To do in Korifi - Backlog Feb 18, 2025
@georgethebeatle georgethebeatle changed the title Separate Korifi's naive logcache implementation as a separate deployment in the helm chart Consume the default logcache implementation securely Feb 18, 2025
@georgethebeatle georgethebeatle changed the title Consume the default logcache implementation securely Do not assume insecure ssl communication with the naive logcache implementation Feb 18, 2025
@georgethebeatle
Copy link
Member Author

georgethebeatle commented Mar 10, 2025

Insecure loopback to localhost is only needed for the kind dev experience. Therefore we do not need to default to localhost here, but rather make the deploy-on-kind.sh and installer scripts to pass the correct helm values

  • Enable external log cache
  • Skip ssl
  • In the helm chart defult the log cache url to :<internal-port>

This way we simplify the code and achieve the defaulting in the helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🇪🇺 To do
Development

No branches or pull requests

1 participant