Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement existing service bindings migration #3820

Open
uzabanov opened this issue Feb 19, 2025 · 0 comments
Open

Implement existing service bindings migration #3820

uzabanov opened this issue Feb 19, 2025 · 0 comments
Assignees

Comments

@uzabanov
Copy link
Contributor

uzabanov commented Feb 19, 2025

When implementing #1949 we considered how wether our new implementation is backwards compatible with 0.14.0. We have managed to migrate a 0.14.0 deployment to main by the following steps:

  • Push an app and bind it to some service
  • Stop korifi-controllers deployment
  • Delete the servicebindingio ServiceBindings for the app
  • Uprade Korifi
  • Restart the app (to recreate the app workload)

As deleting the servicebindingio binding should take place while korifi controllers are down, we could implement those steps in a pre-update helm hook

The manual app restart step is a bit tedious. In order to avoid it could we delete the AppWorkload while korifi controllers are down? Thus when the controllers are upgraded, they would reconcile the apps and create the app workload with desired bindings

@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Feb 19, 2025
@danail-branekov danail-branekov changed the title Improve a pre-upgrade helm hook to migrate existing service bindings Implement existing service bindings migration Feb 19, 2025
@danail-branekov danail-branekov added this to the release-candidate milestone Feb 19, 2025
@danail-branekov danail-branekov moved this from 🧊 Icebox to 🇪🇺 To do in Korifi - Backlog Feb 20, 2025
@danail-branekov danail-branekov moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Feb 20, 2025
@georgethebeatle georgethebeatle moved this from 🔄 In progress to 🇪🇺 To do in Korifi - Backlog Feb 25, 2025
@danail-branekov danail-branekov moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Mar 5, 2025
uzabanov added a commit that referenced this issue Mar 7, 2025
- It will delete the redundant sbio bindings, making sure they are
  refclected in the app status AND restart the app so that it sees the
  new environment
- The migration can be disabled

Co-authored-by: Yusmen Zabanov <[email protected]>

fixes #3820
uzabanov added a commit that referenced this issue Mar 7, 2025
- It will delete the redundant sbio bindings, making sure they are
  refclected in the app status AND restart the app so that it sees the
  new environment
- The migration can be disabled

Co-authored-by: Yusmen Zabanov <[email protected]>

fixes #3820

Co-authored-by: Yusmen Zabanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔄 In progress
Development

No branches or pull requests

2 participants