Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all dummy v3 endpoint implementations #3831

Open
georgethebeatle opened this issue Feb 27, 2025 · 0 comments
Open

Document all dummy v3 endpoint implementations #3831

georgethebeatle opened this issue Feb 27, 2025 · 0 comments
Labels

Comments

@georgethebeatle
Copy link
Member

Background

We know that some of the v3 endpoints in Korifi are dummies that return hardcoded content. These are leftovers from the early days, when certain short-cuts were taken in order to enable the cf push funcionality sooner. However we should consider fixing them to achieve better API compatibility.

What to do

Go over Korifi's http handlers and look for stuff that is hardcoded or implemented in an overly-simplistic way and open issues for every such endopint

Here are some examples:

  • tokenString, err := token.SignedString([]byte("not-a-real-secret"))
    - here a token is hard-coded
  • func (h *App) getAppFeature(r *http.Request) (*routing.Response, error) {
    - here the implementation is overly simplistic
  • Enabled: true,
    Locked: false,
    Metadata: Metadata{
    Labels: map[string]string{},
    Annotations: map[string]string{},
    },
    Links: map[string]Link{},
    - here a part of the resource response is hardcoded, so it is potentilly unused

For each of these simplistic implementations we should find out

  • Can we drop them
  • What use cases do they enable
  • What use cases do they block (by not providing the complete implementation as specified by the api spec)

This context will be important for determining the priority of the resulting stories

@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Feb 27, 2025
@georgethebeatle georgethebeatle changed the title [Explore]: Document all dummy v3 endpoint implementations Document all dummy v3 endpoint implementations Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

1 participant