From 7336dcffb92fd423ee9c7008dec169f5d89f145f Mon Sep 17 00:00:00 2001
From: Maximilian Stefanac <137301184+corporatemax@users.noreply.github.com>
Date: Wed, 8 Jan 2025 15:05:00 +0100
Subject: [PATCH] use grpc port for ingress client from config

---
 src/cmd/syslog-agent/app/syslog_agent.go     | 17 ++++++-----------
 src/pkg/egress/syslog/writer_factory.go      |  8 +++-----
 src/pkg/egress/syslog/writer_factory_test.go |  2 +-
 3 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/src/cmd/syslog-agent/app/syslog_agent.go b/src/cmd/syslog-agent/app/syslog_agent.go
index 810433d36..0f97cc72d 100644
--- a/src/cmd/syslog-agent/app/syslog_agent.go
+++ b/src/cmd/syslog-agent/app/syslog_agent.go
@@ -69,23 +69,18 @@ func NewSyslogAgent(
 	logClient, err := loggregator.NewIngressClient(
 		ingressTLSConfig,
 		loggregator.WithLogger(log.New(os.Stderr, "", log.LstdFlags)),
+		loggregator.WithAddr(fmt.Sprintf("127.0.0.1:%d", cfg.GRPC.Port)),
 	)
 	if err != nil {
 		l.Panicf("failed to create log client for syslog connector: %q", err)
 	}
 
 	internalTlsConfig, externalTlsConfig := drainTLSConfig(cfg)
-	writerFactory := syslog.NewWriterFactory(
-		internalTlsConfig,
-		externalTlsConfig,
-		syslog.NetworkTimeoutConfig{
-			Keepalive:    10 * time.Second,
-			DialTimeout:  10 * time.Second,
-			WriteTimeout: 10 * time.Second,
-		},
-		m,
-		syslog.NewAppLogEmitter(logClient, "syslog_agent"),
-	)
+	writerFactory := syslog.NewWriterFactory(internalTlsConfig, externalTlsConfig, syslog.NetworkTimeoutConfig{
+		Keepalive:    10 * time.Second,
+		DialTimeout:  10 * time.Second,
+		WriteTimeout: 10 * time.Second,
+	}, m)
 
 	connector := syslog.NewSyslogConnector(
 		cfg.DrainSkipCertVerify,
diff --git a/src/pkg/egress/syslog/writer_factory.go b/src/pkg/egress/syslog/writer_factory.go
index 4d3e0e0da..c8ec7c804 100644
--- a/src/pkg/egress/syslog/writer_factory.go
+++ b/src/pkg/egress/syslog/writer_factory.go
@@ -41,16 +41,14 @@ type WriterFactory struct {
 	externalTlsConfig *tls.Config
 	netConf           NetworkTimeoutConfig
 	m                 metricClient
-	emitter           AppLogEmitter
 }
 
-func NewWriterFactory(internalTlsConfig *tls.Config, externalTlsConfig *tls.Config, netConf NetworkTimeoutConfig, m metricClient, emitter AppLogEmitter) WriterFactory {
+func NewWriterFactory(internalTlsConfig *tls.Config, externalTlsConfig *tls.Config, netConf NetworkTimeoutConfig, m metricClient) WriterFactory {
 	return WriterFactory{
 		internalTlsConfig: internalTlsConfig,
 		externalTlsConfig: externalTlsConfig,
 		netConf:           netConf,
 		m:                 m,
-		emitter:           emitter,
 	}
 }
 
@@ -64,7 +62,7 @@ func (f WriterFactory) NewWriter(ub *URLBinding, emitter AppLogEmitter) (egress.
 		if err != nil {
 			errorMessage := err.Error()
 			err = NewWriterFactoryErrorf(ub.URL, "failed to load certificate: %s", errorMessage)
-			f.emitter.EmitLog(ub.AppID, fmt.Sprintf("failed to load certificate: %s", errorMessage))
+			emitter.EmitLog(ub.AppID, fmt.Sprintf("failed to load certificate: %s", errorMessage))
 			return nil, err
 		}
 		tlsCfg.Certificates = []tls.Certificate{cert}
@@ -73,7 +71,7 @@ func (f WriterFactory) NewWriter(ub *URLBinding, emitter AppLogEmitter) (egress.
 		ok := tlsCfg.RootCAs.AppendCertsFromPEM(ub.CA)
 		if !ok {
 			err := NewWriterFactoryErrorf(ub.URL, "failed to load root CA")
-			f.emitter.EmitLog(ub.AppID, "failed to load root CA")
+			emitter.EmitLog(ub.AppID, "failed to load root CA")
 			return nil, err
 		}
 	}
diff --git a/src/pkg/egress/syslog/writer_factory_test.go b/src/pkg/egress/syslog/writer_factory_test.go
index 0ae34fa82..e56d8e41e 100644
--- a/src/pkg/egress/syslog/writer_factory_test.go
+++ b/src/pkg/egress/syslog/writer_factory_test.go
@@ -19,7 +19,7 @@ var _ = Describe("EgressFactory", func() {
 
 	BeforeEach(func() {
 		sm = metricsHelpers.NewMetricsRegistry()
-		f = syslog.NewWriterFactory(&tls.Config{}, &tls.Config{}, syslog.NetworkTimeoutConfig{}, sm, syslog.AppLogEmitter{}) //nolint:gosec
+		f = syslog.NewWriterFactory(&tls.Config{}, &tls.Config{}, syslog.NetworkTimeoutConfig{}, sm) //nolint:gosec
 	})
 
 	Context("when the url begins with https", func() {