Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support CF metadata #1391

Open
corporateuser opened this issue Oct 24, 2023 · 4 comments
Open

[Feature Request] Support CF metadata #1391

corporateuser opened this issue Oct 24, 2023 · 4 comments

Comments

@corporateuser
Copy link

Description

It would be helpful to have ability to specify labels and annotations right in mta/mtad files.

Additional information

It would be nice to have something like:

ID: "my-mta"
_schema-version: 3.3.0
version: 1.0.0

modules:
  #A cf app which will be bound to the service
- name: my-app
  type: application
  path: "appBits.zip"
  requires:
    - name: my-service
  parameters:
    instances: 1
    labels:
     environment: staging
     type: core-modules
    annotations:
      last-change:
        author: John Doe
        date: 12-12-12
        commitId: abc4567
@boyan-velinov
Copy link
Contributor

Hello,

Thanks for providing feedback!

multiapps-controller does not provide support to users to modify CF metadata. However, it uses it to store MTA related data.

I would like to understand more about your use case:

  • Do you use MTA deployment provided by SAP BTP?
  • Do you bring up multiapps-controller on your own?
  • What is the end-to-end scenario?
  • Is it an option to use CF app env instead?

Best Regards,
Boyan

@corporateuser
Copy link
Author

Hello,
I see it as well that metadata is hidden from us in mta/mtad, but in CF manifest it is available.

  1. We use SAP BTP
  2. We use SAP BTP
  3. For now we store in CF space's tag the latest hash, which later we're using to calculate difference between different spaces
  4. Possible, but looks not so right

@corporateuser
Copy link
Author

Another scenario which came to my mind:
For security validation we need to implement rate limiting. For different type of applications rate limiting should be one of 2 types: jwt-based or host-based. Currently we mark our applications with one of 2 types in our script, and store this configuration there.
It would be a nicer solution to make this a label instead and store this in mta[d] file itself where all the configuration is stored. Then we could simply select all the applications with specific rate limiting type with 1 command or api query.
It is possible to store in env variables as well, but this has its own downsides, like polluting env variables, additional calls.

@boyan-velinov
Copy link
Contributor

The current possible way is to do it with env variables. Support of CF metadata is not in the mid-term roadmap of the service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants